Review main Merged

65910[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:impexp

Daniel Goerz CR +2 V +2 Normal +40 −39 updated 09/28/20, 08:06

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1012

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:30

  2. Daniel Goerz wrote 09/26/20, 17:30

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 09/26/20, 17:30

  4. TYPO3com voted on patch set 1 V +1 09/26/20, 17:43 Completed build in 13m 46s on Sat, 26 Sep, 05:43 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6004

  5. Oliver Klee voted on patch set 1 CR +1 09/26/20, 18:59

  6. Andreas Kienast commented on patch set 1 CR -1 09/27/20, 13:03

    ImportCommand.php:85 Unresolved

    I'd do the string cast here instead. This way, we could clean up the guard clause below.
  7. Andreas Kienast uploaded patch set 2 09/27/20, 13:04

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 09/27/20, 13:04

  9. TYPO3com voted on patch set 2 V +1 09/27/20, 13:27 Completed build in 22m 26s on Sun, 27 Sep, 01:27 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6017

  10. Oliver Klee voted on patch set 2 CR +1 09/27/20, 15:02

  11. Benni Mack voted on patch set 2 V +2 CR +2 09/28/20, 08:06

  12. Benni Mack merged patch set 3 09/28/20, 08:06