Review main Merged

65911[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:fluid

Daniel Goerz CR +2 V +2 Easy +24 −21 updated 10/01/20, 13:37

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1317

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:31

  2. Daniel Goerz wrote 09/26/20, 17:32

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 09/26/20, 17:32

  4. TYPO3com voted on patch set 1 V +1 09/26/20, 17:47 Completed build in 13m 45s on Sat, 26 Sep, 05:47 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6005

  5. Oliver Klee voted on patch set 1 CR +1 09/26/20, 19:02

  6. Andreas Kienast commented on patch set 1 V -1 09/27/20, 12:39

    ------ ----------------------------------------------------------------------------------------------------------------------------------------- Line Classes/ViewHelpers/MediaViewHelper.php ------ ----------------------------------------------------------------------------------------------------------------------------------------- 120 Parameter #1 $image of method TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper::renderImage() expects TYPO3\CMS\Core\Resource\FileInterface, TYPO3\CMS\Core\Resource\FileInterface|TYPO3\CMS\Extbase\Domain\Model\AbstractFileFolder given. ------ -----------------------------------------------------------------------------------------------------------------------------------------
  7. Daniel Goerz uploaded patch set 2 09/28/20, 12:47

  8. TYPO3com voted on patch set 2 V -1 09/28/20, 12:47 Completed build in 24s on Mon, 28 Sep, 12:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6039

  9. Daniel Goerz uploaded patch set 3 09/28/20, 12:52

  10. Daniel Goerz commented on patch set 2 09/28/20, 12:53

    > Patch Set 1: Verified-1 > > ------ ----------------------------------------------------------------------------------------------------------------------------------------- > Line Classes/ViewHelpers/MediaViewHelper.php > ------ ----------------------------------------------------------------------------------------------------------------------------------------- > 120 Parameter #1 $image of method TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper::renderImage() expects TYPO3\CMS\Core\Resource\FileInterface, TYPO3\CMS\Core\Resource\FileInterface|TYPO3\CMS\Extbase\Domain\Model\AbstractFileFolder given. > ------ -----------------------------------------------------------------------------------------------------------------------------------------

    MediaViewHelper.php:116 Unresolved

    RendererRegistry::getInstance()->getRenderer($file) expects $file to be instanceof FileInterface, so AbstractFileFolder would fail here.
  11. Daniel Goerz uploaded patch set 4 09/28/20, 13:03

  12. TYPO3com voted on patch set 3 V +1 09/28/20, 13:04 Completed build in 11m 22s on Mon, 28 Sep, 01:04 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6040

  13. TYPO3com voted on patch set 4 V +1 09/28/20, 13:15 Completed build in 11m 27s on Mon, 28 Sep, 01:15 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6042

  14. Daniel Goerz voted on patch set 4 V +1 CR +1 09/28/20, 13:16

  15. Oliver Klee voted on patch set 4 CR +1 09/28/20, 13:26

  16. Benni Mack voted on patch set 4 V +2 CR +2 10/01/20, 13:37

  17. Benni Mack merged patch set 5 10/01/20, 13:37