65911[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:fluid
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+4 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+4 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+4 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/LinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/UriViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+1 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php1+2 −3
Review log 1317
-
Daniel Goerz uploaded patch set 1 09/26/20, 17:31
-
Daniel Goerz wrote 09/26/20, 17:32
Topic set to phpstan -
Daniel Goerz commented on patch set 1 09/26/20, 17:32
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 -
TYPO3com voted on patch set 1 V +1 09/26/20, 17:47 Completed build in 13m 45s on Sat, 26 Sep, 05:47 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6005
-
Oliver Klee voted on patch set 1 CR +1 09/26/20, 19:02
-
Andreas Kienast commented on patch set 1 V -1 09/27/20, 12:39
------ ----------------------------------------------------------------------------------------------------------------------------------------- Line Classes/ViewHelpers/MediaViewHelper.php ------ ----------------------------------------------------------------------------------------------------------------------------------------- 120 Parameter #1 $image of method TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper::renderImage() expects TYPO3\CMS\Core\Resource\FileInterface, TYPO3\CMS\Core\Resource\FileInterface|TYPO3\CMS\Extbase\Domain\Model\AbstractFileFolder given. ------ ----------------------------------------------------------------------------------------------------------------------------------------- -
Daniel Goerz uploaded patch set 2 09/28/20, 12:47
-
TYPO3com voted on patch set 2 V -1 09/28/20, 12:47 Completed build in 24s on Mon, 28 Sep, 12:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6039
-
Daniel Goerz uploaded patch set 3 09/28/20, 12:52
-
Daniel Goerz commented on patch set 2 09/28/20, 12:53
> Patch Set 1: Verified-1 > > ------ ----------------------------------------------------------------------------------------------------------------------------------------- > Line Classes/ViewHelpers/MediaViewHelper.php > ------ ----------------------------------------------------------------------------------------------------------------------------------------- > 120 Parameter #1 $image of method TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper::renderImage() expects TYPO3\CMS\Core\Resource\FileInterface, TYPO3\CMS\Core\Resource\FileInterface|TYPO3\CMS\Extbase\Domain\Model\AbstractFileFolder given. > ------ -----------------------------------------------------------------------------------------------------------------------------------------MediaViewHelper.php:116UnresolvedRendererRegistry::getInstance()->getRenderer($file) expects $file to be instanceof FileInterface, so AbstractFileFolder would fail here. -
Daniel Goerz uploaded patch set 4 09/28/20, 13:03
-
TYPO3com voted on patch set 3 V +1 09/28/20, 13:04 Completed build in 11m 22s on Mon, 28 Sep, 01:04 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6040
-
TYPO3com voted on patch set 4 V +1 09/28/20, 13:15 Completed build in 11m 27s on Mon, 28 Sep, 01:15 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6042
-
Daniel Goerz voted on patch set 4 V +1 CR +1 09/28/20, 13:16
-
Oliver Klee voted on patch set 4 CR +1 09/28/20, 13:26
-
Benni Mack voted on patch set 4 V +2 CR +2 10/01/20, 13:37
-
Benni Mack merged patch set 5 10/01/20, 13:37