Review main Merged

65912[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:filelist

Daniel Goerz CR +2 V +2 Easy +6 −6 updated 09/27/20, 14:19

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Sascha Egerer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1113

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:34

  2. Daniel Goerz wrote 09/26/20, 17:34

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 09/26/20, 17:35

  4. TYPO3com voted on patch set 1 V +1 09/26/20, 17:52 Completed build in 17m 44s on Sat, 26 Sep, 05:52 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6006

  5. Oliver Klee voted on patch set 1 CR +1 09/26/20, 19:01

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 09/27/20, 12:46

  7. Daniel Goerz uploaded patch set 2 09/27/20, 12:53

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 09/27/20, 12:54

  9. TYPO3com voted on patch set 2 V +1 09/27/20, 13:05 Completed build in 11m 49s on Sun, 27 Sep, 01:05 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6013

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 09/27/20, 13:32

  11. Sascha Egerer voted on patch set 2 V +1 CR +1 09/27/20, 14:07

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 09/27/20, 14:19

  13. Andreas Kienast merged patch set 3 09/27/20, 14:19