Review main Merged

65914[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:beuser

Daniel Goerz CR +2 V +2 Easy +22 −19 updated 09/27/20, 13:23

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1013

  1. Daniel Goerz uploaded patch set 1 09/26/20, 17:37

  2. Daniel Goerz wrote 09/26/20, 17:38

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 09/26/20, 17:38

  4. TYPO3com voted on patch set 1 V +1 09/26/20, 18:01 Completed build in 18m 34s on Sat, 26 Sep, 06:01 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6008

  5. Oliver Klee voted on patch set 1 CR +1 09/26/20, 19:00

  6. Andreas Kienast uploaded patch set 2 09/27/20, 12:56

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/27/20, 12:57

  8. Daniel Goerz uploaded patch set 3 09/27/20, 13:04

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 09/27/20, 13:04

  10. TYPO3com voted on patch set 2 V +1 09/27/20, 13:11 Completed build in 14m 17s on Sun, 27 Sep, 01:11 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6014

  11. TYPO3com voted on patch set 3 V +1 09/27/20, 13:19 Completed build in 14m 13s on Sun, 27 Sep, 01:19 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6016

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 09/27/20, 13:23

  13. Andreas Kienast merged patch set 4 09/27/20, 13:23