65915[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:belog
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
-
Verified V +2 Done
- Daniel Goerz +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1114
-
Daniel Goerz uploaded patch set 1 09/26/20, 17:39
-
Daniel Goerz commented on patch set 1 09/26/20, 17:39
Extracted from https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 -
Daniel Goerz wrote 09/26/20, 17:39
Topic set to phpstan -
TYPO3com voted on patch set 1 V +1 09/26/20, 18:07 Completed build in 24m 43s on Sat, 26 Sep, 06:07 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6009
-
Oliver Klee voted on patch set 1 CR +1 09/26/20, 18:56
-
Oli Bartsch voted on patch set 1 V +1 CR +1 09/27/20, 14:12
-
Andreas Kienast commented on patch set 1 V -1 09/27/20, 14:15
There's still something left ------ -------------------------------------------------------------------- Line Classes/Controller/BackendLogController.php ------ -------------------------------------------------------------------- 354 Parameter #4 $mon of function mktime expects int, float|int given. ------ -------------------------------------------------------------------- ------ ---------------------------------------------------------------------------------------------------------------------------------------------- Line ext_tables.php ------ ---------------------------------------------------------------------------------------------------------------------------------------------- 6 Parameter #3 $_unused of static method TYPO3\CMS\Core\Utility\ExtensionManagementUtility::insertModuleFunction() expects string, null given. ------ ---------------------------------------------------------------------------------------------------------------------------------------------- -
Andreas Kienast uploaded patch set 2 09/27/20, 14:16
-
Andreas Kienast uploaded patch set 3 09/27/20, 14:18
-
Andreas Kienast voted on patch set 3 V +1 CR +1 09/27/20, 14:18
-
TYPO3com voted on patch set 2 V +1 09/27/20, 14:29 Completed build in 12m 56s on Sun, 27 Sep, 02:29 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6022
-
TYPO3com voted on patch set 3 V +1 09/27/20, 14:34 Completed build in 14m 15s on Sun, 27 Sep, 02:34 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6023
-
Daniel Goerz voted on patch set 3 V +2 CR +2 09/27/20, 14:56
-
Daniel Goerz merged patch set 4 09/27/20, 14:56