Review main Merged

65916[TASK] Clean up EXT:redirects

Helmut Hummel CR +2 V +2 Hard +337 −581 updated 10/08/20, 14:00

Commit message

* use singular for array command options
* clarify option description
* remove same purpose configuration class and extend demand instead
* remove proxy method in service class
* use demand as argument instead of property
* filter order field against allow list
* use dependency injection
* cleanup superfluous annotations

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 26

Show 6 more files

Review log 1323

  1. Helmut Hummel uploaded patch set 1 09/27/20, 11:30

  2. TYPO3com voted on patch set 1 V -1 09/27/20, 11:31 Completed build in 21s on Sun, 27 Sep, 11:31 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6012

  3. Daniel Goerz uploaded patch set 2 09/27/20, 13:47

  4. TYPO3com voted on patch set 2 V -1 09/27/20, 13:55 Completed build in 08m 24s on Sun, 27 Sep, 01:55 PM Test Summary: 62503 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6021

  5. TYPO3com commented on patch set 2 09/27/20, 14:00 Completed build in 22m 07s on Sun, 27 Sep, 02:00 PM Test Summary: 62503 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6021

  6. Daniel Goerz uploaded patch set 3 09/27/20, 14:48

  7. TYPO3com voted on patch set 3 V -1 09/27/20, 14:48 Completed build in 23s on Sun, 27 Sep, 02:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6026

  8. Daniel Goerz uploaded patch set 4 09/27/20, 14:52

  9. Daniel Goerz updated the commit message in patch set 5 09/27/20, 15:01

  10. TYPO3com voted on patch set 4 V -1 09/27/20, 15:08 Completed build in 14m 25s on Sun, 27 Sep, 03:08 PM Test Summary: 48 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6028

  11. Daniel Goerz uploaded patch set 6 09/27/20, 15:15

  12. TYPO3com voted on patch set 5 V -1 09/27/20, 15:33 Completed build in 30m 05s on Sun, 27 Sep, 03:33 PM Test Summary: 48 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6030

  13. TYPO3com voted on patch set 6 V +1 09/27/20, 15:41 Completed build in 19m 15s on Sun, 27 Sep, 03:41 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6031

  14. Daniel Goerz uploaded patch set 7 10/05/20, 11:57

  15. TYPO3com voted on patch set 7 V -1 10/05/20, 12:05 Completed build in 08m 28s on Mon, 5 Oct, 12:05 PM Test Summary: 62485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6239

  16. Daniel Goerz uploaded patch set 8 10/05/20, 12:11

  17. TYPO3com voted on patch set 8 V +1 10/05/20, 12:23 Completed build in 12m 41s on Mon, 5 Oct, 12:23 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6240

  18. Daniel Goerz voted on patch set 8 V +1 CR +1 10/05/20, 12:56

  19. Daniel Goerz uploaded patch set 9 10/08/20, 11:14

  20. Daniel Goerz voted on patch set 9 V +1 CR +1 10/08/20, 11:15

  21. TYPO3com voted on patch set 9 V +1 10/08/20, 11:36 Completed build in 21m 34s on Thu, 8 Oct, 11:36 AM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6359

  22. Benni Mack voted on patch set 9 V +2 CR +2 10/08/20, 14:00

  23. Benni Mack merged patch set 10 10/08/20, 14:00