Review 10.4 Merged

65917[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:recycler

Andreas Kienast CR +2 V +2 Easy +5 −4 updated 09/27/20, 12:49

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Andreas Kienast uploaded patch set 1 09/27/20, 12:34

  2. Andreas Kienast wrote 09/27/20, 12:34

    Topic set to phpstan-10.4
  3. TYPO3com voted on patch set 1 V +1 09/27/20, 12:45 Completed build in 11m 11s on Sun, 27 Sep, 12:45 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-524

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 09/27/20, 12:49

  5. Andreas Kienast merged patch set 2 09/27/20, 12:49