Review 10.4 Merged

65919[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:recordlist

Andreas Kienast CR +2 V +2 Easy +19 −18 updated 09/28/20, 08:02

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 79

  1. Andreas Kienast uploaded patch set 1 09/27/20, 14:41

  2. TYPO3com voted on patch set 1 V -1 09/27/20, 14:48 Completed build in 38s on Sun, 27 Sep, 02:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-532

  3. Andreas Kienast uploaded patch set 2 09/27/20, 14:50

  4. Daniel Goerz commented on patch set 1 09/27/20, 14:53

    Yes this sysext was quite heavily refactored in master already so we need to manualy adjust this for v10
  5. Oliver Klee voted on patch set 2 CR +1 09/27/20, 15:00

  6. TYPO3com voted on patch set 2 V +1 09/27/20, 15:10 Completed build in 16m 41s on Sun, 27 Sep, 03:10 PM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-533

  7. Andreas Kienast commented on patch set 2 09/27/20, 15:21

    > Patch Set 1: > > Yes this sysext was quite heavily refactored in master already so we need to manualy adjust this for v10 That's why I've added you as a reviewer :). Feel free to merge if this backport is fine for you.
  8. Benni Mack voted on patch set 2 V +2 CR +2 09/28/20, 08:02

  9. Benni Mack merged patch set 3 09/28/20, 08:02