Review main Merged

65920[BUGFIX] Allow empty string in redirects:integritycheck task

Daniel Siepmann CR +2 V +2 Easy +5 −3 updated 10/18/20, 11:34

Commit message

Saving the integritycheck scheduler task a second time without
providing a site identifier will lead to an empty string
being stored.

As the underlying code cant handle an empty string as
identifier, this patch streamlines the input handling and assures
that null is provided instead which means "all sites".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Markus Gerdes +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Gerdes +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2429

Show 34 earlier messages
  1. Daniel Siepmann uploaded patch set 1 09/28/20, 06:35

  2. TYPO3com voted on patch set 1 V +1 09/28/20, 06:48 Completed build in 13m 12s on Mon, 28 Sep, 06:48 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6033

  3. Oli Bartsch commented on patch set 1 09/28/20, 06:55

    CheckIntegrityCommand.php:72

    What about `$input->getArgument('site') ?: null` ?
  4. Mathias Brodala commented on patch set 1 09/28/20, 06:55

    CheckIntegrityCommand.php:72

    I think it would make sense to use this as default for addArgument() in configure() above then.
  1. Daniel Siepmann uploaded patch set 2 09/28/20, 10:08

  2. Daniel Siepmann commented on patch set 2 09/28/20, 10:08

    CheckIntegrityCommand.php:72 Reply

    Checked that one an not use `0` as site identifier. Not sure about other falsy values. But I've migrated to your suggestion.

    CheckIntegrityCommand.php:72 Reply

    Done
  3. Oli Bartsch voted on patch set 2 V +1 CR +1 09/28/20, 10:20

  4. TYPO3com voted on patch set 2 V +1 09/28/20, 10:21 Completed build in 13m 08s on Mon, 28 Sep, 10:21 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6036

  5. Markus Gerdes voted on patch set 2 CR +1 09/29/20, 15:41

  6. Mathias Brodala voted on patch set 2 CR +1 09/29/20, 15:53

  7. Daniel Goerz uploaded patch set 3 10/08/20, 17:19

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 10/08/20, 17:19

  9. TYPO3com voted on patch set 3 V +1 10/08/20, 17:31 Completed build in 12m 17s on Thu, 8 Oct, 05:31 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6379

  10. Markus Gerdes voted on patch set 3 V +1 CR +1 10/08/20, 18:56

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 10/08/20, 19:45

  12. Alexander Schnitzler commented on patch set 3 CR -1 10/09/20, 06:48

    -1 only until questions are answered.
    Sorry but does this describe the current behaviour or the desired one?
    What exactly is a proper value here?

    CheckIntegrityCommand.php:69

    Correct me if I am wrong but do we actually need to have an empty string as default value and use ?: here instead of leaving it null and use ?? here?
  13. Daniel Goerz voted on patch set 3 V +2 CR +2 10/09/20, 06:49

  14. Daniel Goerz voted on patch set 3 V +1 CR +1 10/09/20, 06:49

  15. Markus Gerdes commented on patch set 3 10/15/20, 08:46

    Hi Alexander, I tried to answer your comments, please review.

    Reply

    The current behaviour. After saving the the identifier is ''. This can be viewed in the scheduler list already.

    Reply

    Imo: a proper value would be null (AllSites) or a site identifier. '' does not seem to be a valid identifier, therefore it should be converted to null, at least for the command See IntegretyService->getSites()

    CheckIntegrityCommand.php:69 Reply

    The scheduler shows an input field for the site identifier, which will convert null to ''. Using this change '' corresponds to null for the scheduler, which imo is what one would expect.
  16. Daniel Siepmann uploaded patch set 4 10/16/20, 09:59

  17. Daniel Siepmann commented on patch set 4 10/16/20, 10:01

    Reply Unresolved

    Like Markus wrote. I've rephrased the commit to make it more clear.

    Reply Unresolved

    Like Markus wrote. I've rephrased the commit to make it more clear.

    CheckIntegrityCommand.php:69 Reply Unresolved

    Yes, just like discussed beforehand. I'm up for other ideas. Right now TYPO3 ext:scheduler saves an empty string. Therefore it seems valid to support this as public API by this command. Either provide a specific site, or anything else will result in all sites.
  18. TYPO3com voted on patch set 4 V +1 10/16/20, 10:11 Completed build in 11m 38s on Fri, 16 Oct, 10:11 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6573

  19. Daniel Goerz updated the commit message in patch set 5 10/17/20, 12:53

  20. Daniel Goerz voted on patch set 5 V +1 CR +1 10/17/20, 12:53

  21. TYPO3com voted on patch set 5 V +1 10/17/20, 13:25 Completed build in 14m 31s on Sat, 17 Oct, 01:25 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6617

  22. Oliver Klee voted on patch set 5 CR +1 10/17/20, 13:43

  23. Markus Gerdes voted on patch set 5 V +1 CR +1 10/17/20, 14:05

  24. Daniel Goerz voted on patch set 5 V +2 CR +2 10/18/20, 11:34

  25. Daniel Goerz merged patch set 6 10/18/20, 11:34