65920[BUGFIX] Allow empty string in redirects:integritycheck task
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Markus Gerdes +1
-
Verified V +2 Done
- Daniel Goerz +2
- Markus Gerdes +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2429
Show 34 earlier messages
-
Daniel Siepmann uploaded patch set 1 09/28/20, 06:35
-
TYPO3com voted on patch set 1 V +1 09/28/20, 06:48 Completed build in 13m 12s on Mon, 28 Sep, 06:48 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6033
-
Oli Bartsch commented on patch set 1 09/28/20, 06:55
-
Mathias Brodala commented on patch set 1 09/28/20, 06:55
CheckIntegrityCommand.php:72I think it would make sense to use this as default for addArgument() in configure() above then.
-
Daniel Siepmann uploaded patch set 2 09/28/20, 10:08
-
Daniel Siepmann commented on patch set 2 09/28/20, 10:08
CheckIntegrityCommand.php:72ReplyChecked that one an not use `0` as site identifier. Not sure about other falsy values. But I've migrated to your suggestion.CheckIntegrityCommand.php:72ReplyDone -
Oli Bartsch voted on patch set 2 V +1 CR +1 09/28/20, 10:20
-
TYPO3com voted on patch set 2 V +1 09/28/20, 10:21 Completed build in 13m 08s on Mon, 28 Sep, 10:21 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6036
-
Markus Gerdes voted on patch set 2 CR +1 09/29/20, 15:41
-
Mathias Brodala voted on patch set 2 CR +1 09/29/20, 15:53
-
Daniel Goerz uploaded patch set 3 10/08/20, 17:19
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/08/20, 17:19
-
TYPO3com voted on patch set 3 V +1 10/08/20, 17:31 Completed build in 12m 17s on Thu, 8 Oct, 05:31 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6379
-
Markus Gerdes voted on patch set 3 V +1 CR +1 10/08/20, 18:56
-
Oli Bartsch voted on patch set 3 V +1 CR +1 10/08/20, 19:45
-
Alexander Schnitzler commented on patch set 3 CR -1 10/09/20, 06:48
-1 only until questions are answered.Sorry but does this describe the current behaviour or the desired one?What exactly is a proper value here?CheckIntegrityCommand.php:69Correct me if I am wrong but do we actually need to have an empty string as default value and use ?: here instead of leaving it null and use ?? here? -
Daniel Goerz voted on patch set 3 V +2 CR +2 10/09/20, 06:49
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/09/20, 06:49
-
Markus Gerdes commented on patch set 3 10/15/20, 08:46
Hi Alexander, I tried to answer your comments, please review.Reply
The current behaviour. After saving the the identifier is ''. This can be viewed in the scheduler list already.Reply
Imo: a proper value would be null (AllSites) or a site identifier. '' does not seem to be a valid identifier, therefore it should be converted to null, at least for the command See IntegretyService->getSites()CheckIntegrityCommand.php:69ReplyThe scheduler shows an input field for the site identifier, which will convert null to ''. Using this change '' corresponds to null for the scheduler, which imo is what one would expect. -
Daniel Siepmann uploaded patch set 4 10/16/20, 09:59
-
Daniel Siepmann commented on patch set 4 10/16/20, 10:01
Reply Unresolved
Like Markus wrote. I've rephrased the commit to make it more clear.Reply Unresolved
Like Markus wrote. I've rephrased the commit to make it more clear.CheckIntegrityCommand.php:69Reply UnresolvedYes, just like discussed beforehand. I'm up for other ideas. Right now TYPO3 ext:scheduler saves an empty string. Therefore it seems valid to support this as public API by this command. Either provide a specific site, or anything else will result in all sites. -
TYPO3com voted on patch set 4 V +1 10/16/20, 10:11 Completed build in 11m 38s on Fri, 16 Oct, 10:11 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6573
-
Daniel Goerz updated the commit message in patch set 5 10/17/20, 12:53
-
Daniel Goerz voted on patch set 5 V +1 CR +1 10/17/20, 12:53
-
TYPO3com voted on patch set 5 V +1 10/17/20, 13:25 Completed build in 14m 31s on Sat, 17 Oct, 01:25 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6617
-
Oliver Klee voted on patch set 5 CR +1 10/17/20, 13:43
-
Markus Gerdes voted on patch set 5 V +1 CR +1 10/17/20, 14:05
-
Daniel Goerz voted on patch set 5 V +2 CR +2 10/18/20, 11:34
-
Daniel Goerz merged patch set 6 10/18/20, 11:34
CheckIntegrityCommand.php:72