Review main Merged

65921[TASK] Deprecate StandaloneView for EXT:form EmailFinisher

Oli Bartsch CR +2 V +2 Normal +91 −0 updated 10/02/20, 07:42

Commit message

With #90728 FluidEmail was added to the EXT:form EmailFinisher.
Therefore the StandaloneView has now been deprecated along with
the corresponding configuration option `templatePathAndFilename`,
which can't be used for FluidEmail.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Marcus Schwemer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 09/28/20, 10:04

  2. TYPO3com voted on patch set 1 V +1 09/28/20, 10:16 Completed build in 11m 35s on Mon, 28 Sep, 10:16 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6035

  3. Andreas Kienast commented on patch set 1 09/28/20, 10:30

    EmailFinisher.php:209

    Maybe we should make it clear this relates (very likely) to the configuration of the form itself.
  4. Oli Bartsch commented on patch set 1 09/28/20, 10:53

    EmailFinisher.php:209 Reply

    Ack
  5. Oli Bartsch uploaded patch set 2 09/28/20, 10:58

  6. TYPO3com voted on patch set 2 V +1 09/28/20, 11:09 Completed build in 10m 53s on Mon, 28 Sep, 11:09 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6037

  7. Georg Ringer voted on patch set 2 V +1 CR +1 09/29/20, 08:40

  8. Marcus Schwemer voted on patch set 2 CR +1 09/29/20, 09:49

  9. Benni Mack voted on patch set 2 V +2 CR +2 10/02/20, 07:42

  10. Benni Mack merged patch set 3 10/02/20, 07:42