Review 10.4 Merged

65933[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:indexed_search

Benni Mack CR +2 V +2 Normal +37 −32 updated 09/28/20, 08:58

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 34

  1. Benni Mack commented on patch set 1 09/28/20, 08:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/28/20, 08:40 Completed build in 14m 05s on Mon, 28 Sep, 08:40 AM Test Summary: 74749 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-539

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/28/20, 08:58

  4. Benni Mack merged patch set 2 09/28/20, 08:58