Review main Merged

65952[TASK] Move CleanerTask tests to functional tests

Anja Leichsenring CR +2 V +2 Normal +90 −157 updated 09/29/20, 09:27

Commit message

Unit tests requiring database connection and mocking half the world are
better of to be reimplemented as functional tests.
This has been done to two of CleanerTask tests, which are easier to read
and understand now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1017

  1. Anja Leichsenring uploaded patch set 1 09/28/20, 21:06

  2. Anja Leichsenring uploaded patch set 2 09/28/20, 21:17

  3. Anja Leichsenring uploaded patch set 3 09/28/20, 21:18

  4. TYPO3com voted on patch set 1 V -1 09/28/20, 21:20 Completed build in 13m 31s on Mon, 28 Sep, 09:20 PM Test Summary: 73702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6047

  5. Anja Leichsenring uploaded patch set 4 09/28/20, 21:22

  6. Anja Leichsenring uploaded patch set 5 09/28/20, 21:26

  7. TYPO3com voted on patch set 2 V -1 09/28/20, 21:29 Completed build in 12m 15s on Mon, 28 Sep, 09:29 PM Test Summary: 72653 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6049

  8. TYPO3com voted on patch set 3 V -1 09/28/20, 21:35 Completed build in 15m 49s on Mon, 28 Sep, 09:35 PM Test Summary: 72641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6050

  9. TYPO3com voted on patch set 4 V -1 09/28/20, 22:03 Completed build in 38m 00s on Mon, 28 Sep, 10:03 PM Test Summary: 72641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6053

  10. TYPO3com voted on patch set 5 V -1 09/28/20, 22:19 Completed build in 49m 51s on Mon, 28 Sep, 10:19 PM Test Summary: 72641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6056

  11. TYPO3com commented on patch set 5 09/29/20, 06:48 Completed build in 10h 08m 56s on Tue, 29 Sep, 06:48 AM Test Summary: 72641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6056

  12. Anja Leichsenring uploaded patch set 6 09/29/20, 07:20

  13. TYPO3com voted on patch set 6 V +1 09/29/20, 07:31 Completed build in 11m 01s on Tue, 29 Sep, 07:31 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6061

  14. Christian Kuhn voted on patch set 6 V +1 CR +1 09/29/20, 08:19

  15. Oli Bartsch voted on patch set 6 V +1 CR +1 09/29/20, 08:38

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 09/29/20, 09:27

  17. Christian Kuhn merged patch set 7 09/29/20, 09:27