65962[TASK] Rephrase explanation of sprintf arguments
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Björn Jacob +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1420
-
TYPO3com uploaded patch set 1 09/30/20, 09:17
-
TYPO3com voted on patch set 1 V -1 09/30/20, 09:32 Completed build in 14m 54s on Wed, 30 Sep, 09:32 AM Test Summary: 1 of 74176 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6086
-
Oliver Hader commented on patch set 1 CR -1 09/30/20, 09:36
An example of how the relevant part in the language file looks like help to understand that better... -
Oli Bartsch uploaded patch set 2 09/30/20, 09:36
-
Oli Bartsch uploaded patch set 3 09/30/20, 09:43
-
Oli Bartsch commented on patch set 3 09/30/20, 09:43
> Patch Set 1: Code-Review-1 > > An example of how the relevant part in the language file looks like help to understand that better... Added -
Mathias Brodala commented on patch set 2 09/30/20, 09:44
TranslateViewHelper.php:71UnresolvedActually "%1$s" and "%2$s" would be fine but this should be moved to a different example since the point is mostly about reordering arguments for various languages and also the option to use the same argument multiple times. So this basic example should indeed stick to "%s". -
TYPO3com voted on patch set 2 V +1 09/30/20, 09:58 Completed build in 21m 43s on Wed, 30 Sep, 09:58 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6088
-
TYPO3com voted on patch set 3 V +1 09/30/20, 10:03 Completed build in 19m 30s on Wed, 30 Sep, 10:03 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6089
-
Daniel Goerz uploaded patch set 4 09/30/20, 13:14
-
Daniel Goerz voted on patch set 4 V +1 CR +1 09/30/20, 13:14
-
TYPO3com voted on patch set 4 V +1 09/30/20, 13:31 Completed build in 17m 20s on Wed, 30 Sep, 01:31 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6099
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/30/20, 13:33
-
Daniel Goerz updated the commit message in patch set 5 09/30/20, 13:57
-
Daniel Goerz voted on patch set 5 V +1 CR +1 09/30/20, 13:57
-
TYPO3com voted on patch set 5 V +1 09/30/20, 14:08 Completed build in 10m 56s on Wed, 30 Sep, 02:08 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6101
-
Björn Jacob voted on patch set 5 V +1 CR +1 09/30/20, 14:38
-
Oli Bartsch voted on patch set 5 V +1 CR +1 09/30/20, 17:39
-
Daniel Goerz voted on patch set 5 V +2 CR +2 09/30/20, 19:07
-
Daniel Goerz merged patch set 6 09/30/20, 19:07