Review main Merged

65962[TASK] Rephrase explanation of sprintf arguments

TYPO3com CR +2 V +2 Easy +12 −4 updated 09/30/20, 19:07

Commit message

This patch changes the conversion specification to `%s` while
keeping the reference to the PHP `sprintf()` function and
adds an example of how such a locallang label could look like.

Additionally, the documentation no longer gives the impression that
you can use `%1` (literally) in a language source file.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1420

  1. TYPO3com uploaded patch set 1 09/30/20, 09:17

  2. TYPO3com voted on patch set 1 V -1 09/30/20, 09:32 Completed build in 14m 54s on Wed, 30 Sep, 09:32 AM Test Summary: 1 of 74176 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6086

  3. Oliver Hader commented on patch set 1 CR -1 09/30/20, 09:36

    An example of how the relevant part in the language file looks like help to understand that better...
  4. Oli Bartsch uploaded patch set 2 09/30/20, 09:36

  5. Oli Bartsch uploaded patch set 3 09/30/20, 09:43

  6. Oli Bartsch commented on patch set 3 09/30/20, 09:43

    > Patch Set 1: Code-Review-1 > > An example of how the relevant part in the language file looks like help to understand that better... Added
  7. Mathias Brodala commented on patch set 2 09/30/20, 09:44

    TranslateViewHelper.php:71 Unresolved

    Actually "%1$s" and "%2$s" would be fine but this should be moved to a different example since the point is mostly about reordering arguments for various languages and also the option to use the same argument multiple times. So this basic example should indeed stick to "%s".
  8. TYPO3com voted on patch set 2 V +1 09/30/20, 09:58 Completed build in 21m 43s on Wed, 30 Sep, 09:58 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6088

  9. TYPO3com voted on patch set 3 V +1 09/30/20, 10:03 Completed build in 19m 30s on Wed, 30 Sep, 10:03 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6089

  10. Daniel Goerz uploaded patch set 4 09/30/20, 13:14

  11. Daniel Goerz voted on patch set 4 V +1 CR +1 09/30/20, 13:14

  12. TYPO3com voted on patch set 4 V +1 09/30/20, 13:31 Completed build in 17m 20s on Wed, 30 Sep, 01:31 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6099

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 09/30/20, 13:33

  14. Daniel Goerz updated the commit message in patch set 5 09/30/20, 13:57

  15. Daniel Goerz voted on patch set 5 V +1 CR +1 09/30/20, 13:57

  16. TYPO3com voted on patch set 5 V +1 09/30/20, 14:08 Completed build in 10m 56s on Wed, 30 Sep, 02:08 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6101

  17. Björn Jacob voted on patch set 5 V +1 CR +1 09/30/20, 14:38

  18. Oli Bartsch voted on patch set 5 V +1 CR +1 09/30/20, 17:39

  19. Daniel Goerz voted on patch set 5 V +2 CR +2 09/30/20, 19:07

  20. Daniel Goerz merged patch set 6 09/30/20, 19:07