Review main Merged

65964[TASK] Improve mocking in ConnectionTest to prepare for dbal 2.11

Anja Leichsenring CR +2 V +2 Normal +41 −13 updated 09/30/20, 14:46

Commit message

The tests need some stuff from the constructor to not throw errors now,
so the mock got the required objects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Anja Leichsenring uploaded patch set 1 09/30/20, 11:25

  2. Anja Leichsenring uploaded patch set 2 09/30/20, 11:34

  3. TYPO3com voted on patch set 1 V -1 09/30/20, 11:44 Completed build in 18m 17s on Wed, 30 Sep, 11:44 AM Test Summary: 84 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6092

  4. Anja Leichsenring uploaded patch set 3 09/30/20, 11:53

  5. TYPO3com voted on patch set 3 V -1 09/30/20, 11:56 Completed build in 54s on Wed, 30 Sep, 11:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6095

  6. TYPO3com voted on patch set 2 V +1 09/30/20, 11:57 Completed build in 21m 10s on Wed, 30 Sep, 11:57 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6093

  7. Anja Leichsenring uploaded patch set 4 09/30/20, 12:04

  8. TYPO3com voted on patch set 4 V +1 09/30/20, 12:28 Completed build in 23m 20s on Wed, 30 Sep, 12:28 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6097

  9. Simon Gilli voted on patch set 4 V +1 CR +1 09/30/20, 12:34

  10. Benni Mack voted on patch set 4 V +2 CR +2 09/30/20, 14:46

  11. Benni Mack merged patch set 5 09/30/20, 14:46