Review main Merged

65968[BUGFIX] Do not consider empty files being an image or media file

Helmut Hummel CR +2 V +2 Easy +2 −2 updated 10/16/20, 09:35

Commit message

When creating a new image file the indexing process must not
try to extract width and height, when the file is empty
to avoid warnings.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Helmut Hummel uploaded patch set 1 10/01/20, 09:48

  2. TYPO3com voted on patch set 1 V +1 10/01/20, 10:08 Completed build in 19m 59s on Thu, 1 Oct, 10:08 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6116

  3. Oliver Klee voted on patch set 1 CR +1 10/01/20, 12:19

  4. Josef Glatz commented on patch set 1 10/06/20, 09:25

    Does this also work if a svg image has no width or height attribute set?
  5. Benni Mack voted on patch set 1 CR +1 10/09/20, 19:32

  6. Alexander Schnitzler commented on patch set 1 10/10/20, 06:39

    AbstractFile.php:330

    I do like the change but what do you think about moving the size check into a dedicated method. The naming of this method is not very accurate as we don't really check if a file is an image but only if it's extension is considered to be an image file no matter what binary data I upload actually. I have something like canBeProcessed() in mind. That enables for a better api even if it means more checks and clutter at other points in the code. This also keeps the original api as is just in case people out there rely on this method being as is. Technically, changing the original method would be breaking.
  7. Guido Schmechel commented on patch set 1 10/14/20, 15:23

    Small typo in the commit message: "try to extract width and height"
  8. Markus Klein commented on patch set 1 10/14/20, 17:07

    > Patch Set 1: > > Small typo in the commit message: "try to extract width and height" Please use the edit button right below the commit message to fix such things. Thanks.
  9. Markus Klein updated the commit message in patch set 2 10/14/20, 17:08

  10. Markus Klein voted on patch set 2 V +1 CR +1 10/14/20, 17:08

  11. TYPO3com voted on patch set 2 V +1 10/14/20, 17:28 Completed build in 17m 07s on Wed, 14 Oct, 05:28 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6544

  12. Georg Ringer voted on patch set 2 V +2 CR +2 10/15/20, 18:01

  13. Georg Ringer merged patch set 3 10/15/20, 18:01

  14. Alexander Schnitzler commented on patch set 3 10/16/20, 09:35

    AbstractFile.php:330 Reply Unresolved

    Well, quite sad to be ignored unless you put a -1 somewhere. I tried to avoid that but i seems there is no way around it. :/