Review main Merged

65970[FEATURE] Limit elements in Page module with default language and language mode

Georg Ringer CR +2 V +2 Easy +46 −1 updated 08/04/21, 09:30

Commit message

If the language mode is chosen in the page module and the default
language is selected, only the elements of the default language must be
chosen.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1116

  1. Georg Ringer uploaded patch set 1 10/01/20, 12:19

  2. TYPO3com voted on patch set 1 V +1 10/01/20, 12:32 Completed build in 12m 36s on Thu, 1 Oct, 12:32 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6118

  3. Georg Ringer uploaded patch set 2 10/01/20, 16:48

  4. TYPO3com voted on patch set 2 V +1 10/01/20, 17:02 Completed build in 13m 41s on Thu, 1 Oct, 05:02 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6128

  5. Georg Ringer uploaded patch set 3 10/04/20, 11:32

  6. TYPO3com voted on patch set 3 V +1 10/04/20, 11:44 Completed build in 11m 42s on Sun, 4 Oct, 11:44 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6230

  7. Georg Ringer commented on patch set 3 10/05/20, 06:17

    This change is ready for review.
  8. Oli Bartsch commented on patch set 3 V -1 10/05/20, 12:03

    PageLayoutController.php:261

    This will not work because PageLayoutController calls $configuration->setLanguageColumns($this->MOD_MENU['language']); therefore a column with -1 is registered which is wrong as -1 is no independent column. The language columns are added in PageLayoutView::getSelectedLanguages() to the `$langList`. This list is used to build the columns with their contents. It then breaks e.g. at: Argument 2 passed to TYPO3\CMS\Core\Imaging\IconFactory::getIconForRecord() must be of the type array, bool given, called in /var/www/html/typo3/sysext/backend/Classes/View/PageLayoutView.php on line 758 at TYPO3\CMS\Core\Imaging\IconFactory->getIconForRecord('pages', false, 'small')

    PageLayoutView.php:284

    Here, the -1 is falsely added to the $langList because it is now present in $this->tt_contentConfig['languageCols'].
  9. Oli Bartsch uploaded patch set 4 08/03/21, 23:54

  10. Oli Bartsch uploaded patch set 5 08/04/21, 00:07

  11. Oli Bartsch commented on patch set 5 08/04/21, 00:12

    PageLayoutController.php:261 Reply

    We now remove the -1 from the menu in case the mode is not "languages". Furthermore PageLayoutView::getSelectedLanguages() is not longer used.

    PageLayoutView.php:284 Reply

    Removed this change since PageLayoutView is not longer used.
  12. core-ci voted on patch set 4 V +1 08/04/21, 00:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14066

  13. core-ci voted on patch set 5 V +1 08/04/21, 00:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14067

  14. Oli Bartsch voted on patch set 5 V +1 CR +1 08/04/21, 08:26

  15. Benni Mack voted on patch set 5 V +2 CR +2 08/04/21, 09:30

  16. Benni Mack merged patch set 6 08/04/21, 09:30