Review 10.4 Merged

65973[TASK] Move CleanerTask tests to functional tests

Christian Kuhn CR +2 V +2 Normal +90 −157 updated 09/29/20, 09:41

Commit message

Unit tests requiring database connection and mocking half the world are
better of to be reimplemented as functional tests.
This has been done to two of CleanerTask tests, which are easier to read
and understand now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 34

  1. Christian Kuhn commented on patch set 1 09/29/20, 09:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/29/20, 09:40 Completed build in 12m 25s on Tue, 29 Sep, 09:40 AM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-545

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/29/20, 09:41

  4. Christian Kuhn merged patch set 2 09/29/20, 09:41