Review 10.4 Merged

65976[TASK] Rephrase explanation of sprintf arguments

Daniel Goerz CR +2 V +2 Easy +12 −4 updated 09/30/20, 19:25

Commit message

This patch changes the conversion specification to `%s` while
keeping the reference to the PHP `sprintf()` function and
adds an example of how such a locallang label could look like.

Additionally, the documentation no longer gives the impression that
you can use `%1` (literally) in a language source file.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 09/30/20, 19:07

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/30/20, 19:20 Completed build in 12m 58s on Wed, 30 Sep, 07:20 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-553

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/30/20, 19:25

  4. Daniel Goerz merged patch set 2 09/30/20, 19:25