65977[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:fluid
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
-
Verified V +2 Done
- Daniel Goerz +2
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+4 −1
- typo3/sysext/fluid/Classes/Core/Widget/AbstractWidgetViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+4 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+4 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/LinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/UriViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+1 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+2 −3
Review log 57
-
Benni Mack commented on patch set 1 10/01/20, 13:38
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php -
Benni Mack commented on patch set 1 10/01/20, 13:38
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 10/01/20, 13:38 Completed build in 30s on Thu, 1 Oct, 01:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-554
-
Daniel Goerz uploaded patch set 2 10/01/20, 15:11
-
TYPO3com voted on patch set 2 V +1 10/01/20, 15:32 Completed build in 21m 01s on Thu, 1 Oct, 03:32 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-556
-
Daniel Goerz voted on patch set 2 V +2 CR +2 10/01/20, 15:49
-
Daniel Goerz merged patch set 3 10/01/20, 15:49