Review 10.4 Merged

65977[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:fluid

Benni Mack CR +2 V +2 Easy +23 −20 updated 10/01/20, 15:49

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 57

  1. Benni Mack commented on patch set 1 10/01/20, 13:38

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php
  2. Benni Mack commented on patch set 1 10/01/20, 13:38

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 10/01/20, 13:38 Completed build in 30s on Thu, 1 Oct, 01:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-554

  4. Daniel Goerz uploaded patch set 2 10/01/20, 15:11

  5. TYPO3com voted on patch set 2 V +1 10/01/20, 15:32 Completed build in 21m 01s on Thu, 1 Oct, 03:32 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-556

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 10/01/20, 15:49

  7. Daniel Goerz merged patch set 3 10/01/20, 15:49