Review 10.4 Merged

65978[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core TypoScript

Benni Mack CR +2 V +2 Normal +70 −47 updated 10/01/20, 14:08

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 10/01/20, 13:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/01/20, 13:57 Completed build in 16m 00s on Thu, 1 Oct, 01:57 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-555

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/01/20, 14:08

  4. Benni Mack merged patch set 2 10/01/20, 14:08