Review main Merged

65992[FEATURE] Add `defaultValues` argument to newRecord ViewHelpers

Philipp Parzer CR +2 V +2 Normal +146 −8 updated 10/03/20, 11:19

Commit message

The <be:link.newRecord> and <be:url.newRecord> ViewHelpers now
have a new optional argument `defaultValues` which can be used to
set default values (`defVals`) for fields of the new record.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 2435

Show 710 earlier messages
  1. Philipp Parzer uploaded patch set 1 10/01/20, 14:41

  2. Mathias Brodala commented on patch set 1 CR -1 10/01/20, 14:44

    Please add a feature RST.

    EditRecordViewHelper.php:75 Unresolved

    This should be named "defaults" or "defaultValues". Don't repeat the errors of the past. ;-)
  3. Oli Bartsch commented on patch set 1 V -1 10/01/20, 14:54

    defVals are only used for `new` not for an `edit` of a record. See e.g. `fields` (`columnsOnly`) which is only available in the EditRecordViewHelpers.
  4. TYPO3com voted on patch set 1 V +1 10/01/20, 14:54 Completed build in 12m 54s on Thu, 1 Oct, 02:54 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6123

  5. Philipp Parzer uploaded patch set 2 10/01/20, 15:07

  6. Philipp Parzer uploaded patch set 3 10/01/20, 15:13

  7. TYPO3com voted on patch set 2 V +1 10/01/20, 15:26 Completed build in 18m 48s on Thu, 1 Oct, 03:26 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6124

  8. TYPO3com voted on patch set 3 V +1 10/01/20, 15:32 Completed build in 15m 55s on Thu, 1 Oct, 03:32 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6125

  9. Georg Ringer commented on patch set 3 CR -1 10/01/20, 16:29

    please change the name to "defaultValues", no need to stick to ugly names for new APIs

    NewRecordViewHelper.php:95 Unresolved

    pls set 5th parameter to []

    NewRecordViewHelper.php:76 Unresolved

    pls set 5th parameter to []
  10. Philipp Parzer uploaded patch set 4 10/01/20, 18:45

  1. Oli Bartsch commented on patch set 4 V -1 10/01/20, 18:50

    On it
  2. TYPO3com voted on patch set 4 V +1 10/01/20, 18:59 Completed build in 14m 34s on Thu, 1 Oct, 06:59 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6136

  3. Oli Bartsch uploaded patch set 5 10/01/20, 21:05

  4. Oli Bartsch voted on patch set 5 V +1 CR +1 10/01/20, 21:17

  5. TYPO3com voted on patch set 5 V +1 10/01/20, 21:21 Completed build in 15m 39s on Thu, 1 Oct, 09:21 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6146

  6. Georg Ringer commented on patch set 5 10/01/20, 21:22

    NewRecordViewHelper.php:72

    can we have a nice example just as in the rst --- <be:link.newRecord table="tt_content" pid="17" defaultValues="{tt_content: {header: 'value'}} --- i like those a lot more because easier to understand and more real world
  7. Oli Bartsch commented on patch set 6 10/01/20, 21:22

    Published edit on patch set 5.
  8. Oli Bartsch voted on patch set 6 V +1 CR +1 10/01/20, 21:22

  9. Oli Bartsch commented on patch set 6 10/01/20, 21:27

    NewRecordViewHelper.php:72 Reply Unresolved

    General yes. Actually we then have to change all examples to be consistent in the class. Would suggest to do that in a separat patch. This could also include more such examples in other VHs as well.
  10. TYPO3com voted on patch set 6 V +1 10/01/20, 21:39 Completed build in 16m 36s on Thu, 1 Oct, 09:39 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6148

  11. Georg Ringer voted on patch set 6 V +1 CR +1 10/01/20, 21:40

  12. Mathias Brodala commented on patch set 6 CR +1 10/02/20, 06:45

    I love what this has become. :-)
  13. Christian Kuhn commented on patch set 6 10/02/20, 18:58

    Unresolved

    typo in defaul-T-Values
  14. Christian Kuhn updated the commit message in patch set 7 10/02/20, 18:58

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 10/02/20, 18:58

  16. Oli Bartsch voted on patch set 7 V +1 CR +1 10/02/20, 19:04

  17. TYPO3com voted on patch set 7 V -1 10/02/20, 19:17 Completed build in 19m 12s on Fri, 2 Oct, 07:17 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224

  18. TYPO3com commented on patch set 7 10/02/20, 19:27 Completed build in 48m 14s on Fri, 2 Oct, 07:27 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224

  19. TYPO3com commented on patch set 7 10/02/20, 19:39 Completed build in 1h 29m 13s on Fri, 2 Oct, 07:39 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224

  20. Christian Kuhn rebased onto patch set 8 10/02/20, 20:06

  21. TYPO3com commented on patch set 7 10/02/20, 20:06 Completed build in 2h 37m 43s on Fri, 2 Oct, 08:06 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224

  22. TYPO3com voted on patch set 8 V +1 10/02/20, 20:29 Completed build in 20m 45s on Fri, 2 Oct, 08:29 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6227

  23. Oli Bartsch voted on patch set 8 V +1 CR +1 10/02/20, 21:43

  24. Georg Ringer voted on patch set 8 V +2 CR +2 10/03/20, 11:19

  25. Georg Ringer merged patch set 9 10/03/20, 11:19