Review main Merged

65994[BUGFIX] Do not read workspace if there is no BE user

Markus Klein CR +2 V +2 Easy +2 −2 updated 10/06/20, 08:21

Commit message

Running the PopulatePageSlugs upgrade uses the SlugService
to generate the slugs. SlugService itself uses
BackendUtility::getRecordLocalization() which
does a DB query using a WorkspaceRestriction.
This restriction uses the workspace of the current
BE user. But within the Install Tool upgrade there is no
such user of course.

Add the necessary condition to avoid a PHP type error.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Philipp Parzer +1
    • Johannes Kasberger +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 2329

Show 24 earlier messages
  1. Markus Klein uploaded patch set 1 10/01/20, 17:21

  2. TYPO3com voted on patch set 1 V -1 10/01/20, 17:33 Completed build in 12m 02s on Thu, 1 Oct, 05:33 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6130

  3. Markus Klein commented on patch set 2 10/01/20, 17:40

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 10/01/20, 17:41 Completed build in 23s on Thu, 1 Oct, 05:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6131

  1. Georg Ringer uploaded patch set 3 10/01/20, 17:51

  2. TYPO3com voted on patch set 3 V +1 10/01/20, 18:03 Completed build in 12m 47s on Thu, 1 Oct, 06:03 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6132

  3. Philipp Parzer voted on patch set 3 CR +1 10/01/20, 18:36

  4. Oli Bartsch commented on patch set 3 10/01/20, 18:48

    Also implement this check in BackendUtility::getProcessedValue() ?
  5. Markus Klein commented on patch set 3 10/01/20, 19:48

    > Patch Set 3: > > Also implement this check in BackendUtility::getProcessedValue() ? Well, basically this check should be anywhere where BE_USER might be null, but I think this is a rather rare case, like with the upgrade here. So, I wouldn't blow this patch up any further.
  6. Guido Schmechel voted on patch set 3 CR +1 10/01/20, 21:05

  7. Johannes Kasberger voted on patch set 3 V +1 CR +1 10/02/20, 07:14

  8. Simon Gilli voted on patch set 3 V +1 CR +1 10/02/20, 08:43

  9. Christian Kuhn updated the commit message in patch set 4 10/02/20, 09:01

  10. Christian Kuhn commented on patch set 4 V +1 CR +1 10/02/20, 09:01

    Revotes, pls: Dropped 9.5 and added relation to #92209 which introduced this regression.
  11. TYPO3com voted on patch set 4 V +1 10/02/20, 09:15 Completed build in 14m 19s on Fri, 2 Oct, 09:15 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6154

  12. Oliver Klee voted on patch set 4 CR +1 10/02/20, 10:14

  13. Helmut Hummel commented on patch set 4 10/02/20, 10:56

    BackendUtility.php:293

    static::getBackendUserAuthentication()->workspace ?? 0 would work as well here
  14. Johannes Kasberger voted on patch set 4 V +1 CR +1 10/02/20, 12:21

  15. Markus Klein commented on patch set 4 10/05/20, 13:48

    BackendUtility.php:293 Reply

    Right, wasn't ware of this, but correct.
  16. Markus Klein commented on patch set 5 10/05/20, 13:48

    Published edit on patch set 4.
  17. Oliver Klee updated the commit message in patch set 6 10/05/20, 13:53

  18. Johannes Kasberger voted on patch set 6 V +1 CR +1 10/05/20, 13:57

  19. TYPO3com voted on patch set 5 V +1 10/05/20, 14:04 Completed build in 15m 13s on Mon, 5 Oct, 02:04 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6241

  20. TYPO3com voted on patch set 6 V +1 10/05/20, 14:07 Completed build in 13m 16s on Mon, 5 Oct, 02:07 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6242

  21. Oliver Klee voted on patch set 6 CR +1 10/05/20, 14:24

  22. Torben Hansen voted on patch set 6 CR +1 10/06/20, 06:45

  23. Philipp Parzer voted on patch set 6 CR +1 10/06/20, 07:55

  24. Georg Ringer voted on patch set 6 V +2 CR +2 10/06/20, 08:21

  25. Georg Ringer merged patch set 7 10/06/20, 08:21