Review main Abandoned

65995[BUGFIX] Catch exception during unserializing task

Georg Ringer CR 0 V 0 Easy +25 −18 updated 02/05/22, 10:11

Commit message

If the class can't be unserialized, an exception should be caught to
avoid having a state which is not solvable via backend anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1319

  1. Georg Ringer uploaded patch set 1 10/01/20, 18:29

  2. TYPO3com voted on patch set 1 V -1 10/01/20, 18:50 Completed build in 21m 02s on Thu, 1 Oct, 06:50 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6133

  3. Georg Ringer rebased onto patch set 2 10/19/21, 18:57

  4. core-ci voted on patch set 2 V -1 10/19/21, 19:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18341

  5. Benni Mack updated the commit message in patch set 3 10/21/21, 15:05

  6. core-ci voted on patch set 3 V -1 10/21/21, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18403

  7. Benni Mack wrote 11/29/21, 10:11

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 4 11/29/21, 13:34

  9. core-ci voted on patch set 4 V -1 11/29/21, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20046

  10. Benni Mack commented on patch set 4 01/10/22, 09:07

    What's missing to make this patch ready?
  11. Georg Ringer commented on patch set 4 01/10/22, 10:03

    @benni just fixing the phpstan issue but will take care
  12. Georg Ringer uploaded patch set 5 01/10/22, 14:00

  13. core-ci voted on patch set 5 V -1 01/10/22, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21857

  14. Georg Ringer uploaded patch set 6 01/11/22, 14:23

  15. Georg Ringer commented on patch set 6 01/11/22, 14:23

    This change is ready for review.
  16. core-ci voted on patch set 6 V +1 01/11/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21911

  17. Nikita Hovratov commented on patch set 6 01/23/22, 00:06

    Hey, I picked up the patch here, because of heavy merge conflicts: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73130
  18. Christian Kuhn commented on patch set 6 02/05/22, 10:11

    we pick this patch as the v11 backport version: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73302
  19. Christian Kuhn abandoned the change 02/05/22, 10:11