Review main Abandoned Breaking

65998[WIP][!!!][TASK] Require an extension name for <f:translate>

Benni Mack CR 0 V 0 Hard +434 −483 updated 11/30/20, 10:28

Commit message

The "magic" for using <f:translate key="hello" /> to automatically
resolve the extension name for the value is removed, as it is bound
to controller logic from Extbase. This is needed to decouple
the actual view-logic (Fluid) from Extbase and Extbase from EXT:core
and build a more flexible View functionality for the future.

This means:
if you are using <f:translate id="mykey"> you always need to provide
an extension name as well (<f:translate id="mykey" extensionName="myext" />)
to avoid ambiguity. If you are using extensionName already in your templates,
you're safe.

if you are using <f:translate id="LLL:EXT:myext/Resources/Private/Language/myfile.xlf:mykey"/>
already, you are safe as well.

Templates to do:
* beuser
* extensionmanager

Review

  • Code review CR 0
  • Verified V 0

Files 97

Show 77 more files

Review log 35

  1. Benni Mack uploaded patch set 1 10/02/20, 08:32

  2. TYPO3com voted on patch set 1 V -1 10/02/20, 08:46 Completed build in 13m 18s on Fri, 2 Oct, 08:45 AM Test Summary: 33 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6153

  3. Benni Mack uploaded patch set 2 10/02/20, 09:36

  4. TYPO3com voted on patch set 2 V -1 10/02/20, 09:54 Completed build in 16m 16s on Fri, 2 Oct, 09:54 AM Test Summary: 26 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6157

  5. Benni Mack abandoned the change 11/30/20, 10:28

    won't do for now