Review main Merged

65999[BUGFIX] Use correct page id for permission calculation of inline controls

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/02/20, 14:41

Commit message

For the inline record header controls the InlineRecordContainer calculates
the permissions for the page, the record is on. Previously the calculation
was based on the records pid. This does not work for new records as the
pid is a negative integer in this case - uid of the record the `new` button
was pressed on - and therefore led to no header controls were displayed
till the record was saved.

The calculation now uses the correct uid from `parentPageRow`.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 10/02/20, 10:22

  2. Oli Bartsch updated the commit message in patch set 2 10/02/20, 10:24

  3. TYPO3com voted on patch set 1 V +1 10/02/20, 10:44 Completed build in 21m 41s on Fri, 2 Oct, 10:44 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6161

  4. TYPO3com voted on patch set 2 V +1 10/02/20, 10:48 Completed build in 19m 59s on Fri, 2 Oct, 10:48 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6162

  5. Oliver Klee commented on patch set 2 10/02/20, 10:57

    InlineRecordContainer.php:448

    After reading through all those PHPStan changes: Do we need an int cast here?
  6. Oli Bartsch uploaded patch set 3 10/02/20, 13:23

  7. Oli Bartsch commented on patch set 3 10/02/20, 13:30

    InlineRecordContainer.php:448 Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 10/02/20, 13:58 Completed build in 25m 23s on Fri, 2 Oct, 01:57 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6183

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 10/02/20, 14:13

  10. Oliver Klee voted on patch set 3 CR +1 10/02/20, 14:38

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 10/02/20, 14:41

  12. Anja Leichsenring merged patch set 4 10/02/20, 14:41