Review 10.4 Merged

66002[BUGFIX] Use correct page id for permission calculation of inline controls

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/02/20, 15:39

Commit message

For the inline record header controls the InlineRecordContainer calculates
the permissions for the page, the record is on. Previously the calculation
was based on the records pid. This does not work for new records as the
pid is a negative integer in this case - uid of the record the `new` button
was pressed on - and therefore led to no header controls were displayed
till the record was saved.

The calculation now uses the correct uid from `parentPageRow`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 10/02/20, 14:50

  2. TYPO3com voted on patch set 1 V +1 10/02/20, 15:37 Completed build in 43m 40s on Fri, 2 Oct, 03:37 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-560

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/02/20, 15:39

  4. Christian Kuhn merged patch set 2 10/02/20, 15:39