Review main Merged

66004[TASK] Raise typo3/testing-framework to 6.4.4

Anja Leichsenring CR +2 V +2 Easy +10 −15 updated 10/06/20, 17:58

Commit message

This provides the phpunit prophecy trait to phpunit v8.

Used command:
	composer require --dev typo3/testing-framework:^6.4.4

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Anja Leichsenring uploaded patch set 1 10/02/20, 16:57

  2. Anja Leichsenring wrote 10/02/20, 16:57

    Topic set to testing
  3. TYPO3com voted on patch set 1 V -1 10/02/20, 17:38 Completed build in 23m 12s on Fri, 2 Oct, 05:38 PM Test Summary: 2 of 74220 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6220

  4. Anja Leichsenring uploaded patch set 2 10/02/20, 18:38

  5. TYPO3com commented on patch set 1 10/02/20, 18:38 Completed build in 1h 46m 52s on Fri, 2 Oct, 06:38 PM Test Summary: 73735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6220

  6. Oliver Klee voted on patch set 2 CR +1 10/02/20, 18:47

  7. TYPO3com voted on patch set 2 V +1 10/02/20, 18:57 Completed build in 19m 09s on Fri, 2 Oct, 06:57 PM Test Summary: 73733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6223

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 10/02/20, 19:01

  9. Christian Kuhn commented on patch set 2 V +2 CR +2 10/02/20, 19:03

    hope it's ok if i merge and backport this one right away.
  10. Christian Kuhn merged patch set 3 10/02/20, 19:03

  11. Oliver Hader commented on patch set 3 10/06/20, 13:39

  12. Anja Leichsenring commented on patch set 3 10/06/20, 17:58