Review main Merged

66009[TASK] Updated docblock for addTcaSelectItem()

TYPO3com CR +2 V +2 Easy +3 −0 updated 10/04/20, 15:11

Commit message

Described optional 4th parameter for the $item array, which is used to add
items to defined groups from addTcaSelectItemGroup().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. TYPO3com uploaded patch set 1 10/04/20, 12:33

  2. TYPO3com voted on patch set 1 V +1 10/04/20, 12:44 Completed build in 11m 24s on Sun, 4 Oct, 12:44 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6231

  3. Daniel Haupt commented on patch set 1 V +1 CR +1 10/04/20, 14:45

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 10/04/20, 15:10

  5. Christian Kuhn commented on patch set 1 10/04/20, 15:11

    Improving api docs would be nice if they are not clear enough, yet.
  6. Christian Kuhn merged patch set 2 10/04/20, 15:11