Review main Merged

66011[BUGFIX] Add missing deleted restriction in PlainDataResolver

Christian Kuhn CR +2 V +2 Easy +18 −10 updated 03/08/21, 09:58

Commit message

One last place in PlainDataResolver now gets the
missing DeletedRestriction added to a query.

This should stabilize some usages in DataHandler
and a couple of other places.

A detail with workspace inline scenarios and delete
placeholders with sorting is changed together with
the patch to not trigger side effects. The scenario
is described in detail with a code comment.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1322

  1. Christian Kuhn uploaded patch set 1 10/04/20, 15:53

  2. TYPO3com voted on patch set 1 V -1 10/04/20, 16:07 Completed build in 13m 22s on Sun, 4 Oct, 04:07 PM Test Summary: 1 of 74228 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6233

  3. TYPO3com commented on patch set 1 10/07/20, 10:38 Completed build in 18h 57m 58s on Wed, 7 Oct, 10:38 AM Test Summary: 1 of 74228 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6233

  4. Christian Kuhn rebased onto patch set 2 11/23/20, 11:15

  5. TYPO3com voted on patch set 2 V -1 11/24/20, 10:12 Completed build in 10m 49s on Tue, 24 Nov, 10:12 AM Test Summary: 1 of 32632 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7537

  6. Christian Kuhn uploaded patch set 3 12/20/20, 13:05

  7. TYPO3com voted on patch set 3 V -1 12/20/20, 13:15 Completed build in 09m 38s on Sun, 20 Dec, 01:15 PM Test Summary: 1 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8343

  8. Christian Kuhn commented on patch set 3 CR -1 12/20/20, 13:23

    hmpf. still -1 from postgres ... will have to dig deeper.
  9. Christian Kuhn rebased onto patch set 4 01/12/21, 12:27

  10. Christian Kuhn updated the commit message in patch set 5 01/12/21, 12:40

  11. TYPO3com voted on patch set 4 V -1 01/12/21, 12:40 Completed build in 12m 34s on Tue, 12 Jan, 12:40 PM Test Summary: 1 of 31326 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8826

  12. TYPO3com voted on patch set 5 V -1 01/12/21, 12:51 Completed build in 10m 41s on Tue, 12 Jan, 12:51 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8827

  13. Christian Kuhn voted on patch set 5 CR -1 01/12/21, 12:53

  14. Christian Kuhn uploaded patch set 6 01/13/21, 17:32

  15. TYPO3com voted on patch set 6 V +1 01/13/21, 17:42 Completed build in 10m 05s on Wed, 13 Jan, 05:42 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8852

  16. Christian Kuhn updated the commit message in patch set 7 01/13/21, 18:46

  17. Christian Kuhn rebased onto patch set 8 03/07/21, 23:36

  18. TYPO3com voted on patch set 8 V +1 03/07/21, 23:44 Completed build in 07m 40s on Sun, 7 Mar, 11:43 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9915

  19. core-ci voted on patch set 8 V +1 03/07/21, 23:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1257

  20. Jochen Roth voted on patch set 8 V +1 CR +1 03/08/21, 09:00

  21. Richard Haeser voted on patch set 8 V +2 CR +2 03/08/21, 09:58

  22. Richard Haeser merged patch set 9 03/08/21, 09:58