66012[FEATURE] TypoScript Condition for page layout
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Daniel Siepmann +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Daniel Siepmann +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+5 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-88276-TypoScriptConditionForPageLayout.rstnew+36 −0
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php2+5 −1
Review log 1418
-
Georg Ringer uploaded patch set 1 10/04/20, 18:43
-
Georg Ringer commented on patch set 1 10/04/20, 18:44
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 10/04/20, 18:57 Completed build in 13m 12s on Sun, 4 Oct, 06:57 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6234
-
Daniel Siepmann commented on patch set 1 10/05/20, 06:00
ConditionMatcher.php:51That way it only will work in Frontend? Would be cool to also have it working for Backend (E.g. TSConfig to enable / disable certain page fields based on page layout). -
Josef Glatz commented on patch set 1 10/05/20, 06:20
ConditionMatcher.php:51Reply UnresolvedGreat idea Daniel! Another idea which is technically independent from this patch: Having this info in the fluid backend previews for content elements would be also really cool. With that it's possible to react to page relevant infos. I'm actually using a nasty implementation via PageLayout hook and use it in the standalone fluid templates for backend previews or/and in FormDataProviders, if it is necessary to do different things for one CType on different backendLayout in a historically grown project :-/ -
Georg Ringer uploaded patch set 2 10/05/20, 17:29
-
TYPO3com voted on patch set 2 V -1 10/05/20, 17:30 Completed build in 23s on Mon, 5 Oct, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6245
-
Georg Ringer uploaded patch set 3 10/05/20, 18:41
-
TYPO3com voted on patch set 3 V +1 10/05/20, 18:56 Completed build in 15m 25s on Mon, 5 Oct, 06:56 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6248
-
Daniel Siepmann voted on patch set 3 V +1 CR +1 10/06/20, 05:54
-
Josef Glatz voted on patch set 3 CR +1 10/06/20, 06:19
-
Josef Glatz voted on patch set 3 V +1 10/06/20, 06:36
-
Josef Glatz commented on patch set 4 10/06/20, 06:36
Published edit on patch set 3. -
Josef Glatz voted on patch set 4 V +1 CR +1 10/06/20, 06:36
-
Daniel Siepmann voted on patch set 4 V +1 CR +1 10/06/20, 06:48
-
TYPO3com voted on patch set 4 V +1 10/06/20, 06:50 Completed build in 13m 59s on Tue, 6 Oct, 06:50 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6255
-
Benni Mack voted on patch set 4 V +2 CR +2 10/07/20, 08:17
-
Benni Mack merged patch set 5 10/07/20, 08:17