Review main Merged

66012[FEATURE] TypoScript Condition for page layout

Georg Ringer CR +2 V +2 Easy +46 −2 updated 10/07/20, 08:17

Commit message

Add a new condition using the PageLayoutResolver to let integrators
check for the used backend layout of a page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1418

  1. Georg Ringer uploaded patch set 1 10/04/20, 18:43

  2. Georg Ringer commented on patch set 1 10/04/20, 18:44

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 10/04/20, 18:57 Completed build in 13m 12s on Sun, 4 Oct, 06:57 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6234

  4. Daniel Siepmann commented on patch set 1 10/05/20, 06:00

    ConditionMatcher.php:51

    That way it only will work in Frontend? Would be cool to also have it working for Backend (E.g. TSConfig to enable / disable certain page fields based on page layout).
  5. Josef Glatz commented on patch set 1 10/05/20, 06:20

    ConditionMatcher.php:51 Reply Unresolved

    Great idea Daniel! Another idea which is technically independent from this patch: Having this info in the fluid backend previews for content elements would be also really cool. With that it's possible to react to page relevant infos. I'm actually using a nasty implementation via PageLayout hook and use it in the standalone fluid templates for backend previews or/and in FormDataProviders, if it is necessary to do different things for one CType on different backendLayout in a historically grown project :-/
  6. Georg Ringer uploaded patch set 2 10/05/20, 17:29

  7. TYPO3com voted on patch set 2 V -1 10/05/20, 17:30 Completed build in 23s on Mon, 5 Oct, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6245

  8. Georg Ringer uploaded patch set 3 10/05/20, 18:41

  9. TYPO3com voted on patch set 3 V +1 10/05/20, 18:56 Completed build in 15m 25s on Mon, 5 Oct, 06:56 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6248

  10. Daniel Siepmann voted on patch set 3 V +1 CR +1 10/06/20, 05:54

  11. Josef Glatz voted on patch set 3 CR +1 10/06/20, 06:19

  12. Josef Glatz voted on patch set 3 V +1 10/06/20, 06:36

  13. Josef Glatz commented on patch set 4 10/06/20, 06:36

    Published edit on patch set 3.
  14. Josef Glatz voted on patch set 4 V +1 CR +1 10/06/20, 06:36

  15. Daniel Siepmann voted on patch set 4 V +1 CR +1 10/06/20, 06:48

  16. TYPO3com voted on patch set 4 V +1 10/06/20, 06:50 Completed build in 13m 59s on Tue, 6 Oct, 06:50 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6255

  17. Benni Mack voted on patch set 4 V +2 CR +2 10/07/20, 08:17

  18. Benni Mack merged patch set 5 10/07/20, 08:17