Review main Merged

66014[BUGFIX] Pass defLangBinding to generateLanguageView

Oli Bartsch CR +2 V +2 Easy +8 −3 updated 10/05/20, 16:30

Commit message

In #90315 the PageLayoutView was refactored. Mainly
`getTable_tt_content` was spitted in smaller functions.

Therefore a new function `generateLanguageView` was
introduced but missed `defLangBinding` in the parameter
signature. The parameter is now registered and correctly
passed to the function.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 10/05/20, 07:47

  2. Oli Bartsch rebased onto patch set 2 10/05/20, 07:49

  3. TYPO3com voted on patch set 1 V +1 10/05/20, 08:03 Completed build in 15m 45s on Mon, 5 Oct, 08:03 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6235

  4. TYPO3com voted on patch set 2 V +1 10/05/20, 08:05 Completed build in 15m 52s on Mon, 5 Oct, 08:05 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6236

  5. Mathias Brodala voted on patch set 2 V +1 CR +1 10/05/20, 13:03

  6. Georg Ringer voted on patch set 2 V +2 CR +2 10/05/20, 16:30

  7. Georg Ringer merged patch set 3 10/05/20, 16:30