Review main Merged

66015[BUGFIX] Provide colPos for each cell in defLangBinding view

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 11/03/20, 23:17

Commit message

When dragging content elements in page module, the colPos
value of the dragged element is updated based on the dropped
area. A drop area is a table cell `td` in which the elements are
placed as `div`. The cell itself has the colPos set via a data
attribute. This means moving an element (`div`) to another
cell (`td`), the element gets updated with the colPos of the
new cell.

This did not work if `defLangBinding` was activated because
all elements are then assigned to separate cells which missed
the colPos information completely.

The colPos information is now added to all cells in the
`defLangBinding` view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Oli Bartsch uploaded patch set 1 10/05/20, 10:06

  2. TYPO3com voted on patch set 1 V +1 10/05/20, 10:18 Completed build in 12m 06s on Mon, 5 Oct, 10:18 AM Test Summary: 73741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6237

  3. Mathias Brodala voted on patch set 1 V +1 CR +1 10/05/20, 13:07

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/03/20, 23:17

  5. Benni Mack merged patch set 2 11/03/20, 23:17