66017[TASK] Remove usage of ObjectManager::get in EXT:belog ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 910
-
Georg Ringer uploaded patch set 1 10/05/20, 18:03
-
Georg Ringer commented on patch set 1 10/05/20, 18:04
This change is ready for review. -
Oliver Klee voted on patch set 1 CR +1 10/05/20, 18:09
-
TYPO3com voted on patch set 1 V +1 10/05/20, 18:16 Completed build in 11m 59s on Mon, 5 Oct, 06:16 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6247
-
Daniel Goerz voted on patch set 1 CR +1 10/05/20, 19:00
-
Alexander Schnitzler commented on patch set 1 10/06/20, 10:38
UsernameViewHelper.php:62I'm not really sure if this does the same like before. getRecord does not include deleted records, but hidden ones. I don't remember if Extbase behaves the same here and I would like to have someone double check. -
Benni Mack voted on patch set 1 V +1 CR +1 10/07/20, 08:02
-
Daniel Goerz commented on patch set 1 10/07/20, 16:54
UsernameViewHelper.php:62Reply UnresolvedNow the names of hidden user records are still rendered in the log, which I consider an improvement. -
Daniel Goerz voted on patch set 1 V +2 CR +2 10/07/20, 16:55
-
Daniel Goerz merged patch set 2 10/07/20, 16:55