Review main Merged

66017[TASK] Remove usage of ObjectManager::get in EXT:belog ViewHelpers

Georg Ringer CR +2 V +2 Easy +6 −18 updated 10/07/20, 16:55

Commit message

With #90803 the ObjectManager::get has been deprecated. Remove its
usages from the ViewHelpers of EXT:belog.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Georg Ringer uploaded patch set 1 10/05/20, 18:03

  2. Georg Ringer commented on patch set 1 10/05/20, 18:04

    This change is ready for review.
  3. Oliver Klee voted on patch set 1 CR +1 10/05/20, 18:09

  4. TYPO3com voted on patch set 1 V +1 10/05/20, 18:16 Completed build in 11m 59s on Mon, 5 Oct, 06:16 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6247

  5. Daniel Goerz voted on patch set 1 CR +1 10/05/20, 19:00

  6. Alexander Schnitzler commented on patch set 1 10/06/20, 10:38

    UsernameViewHelper.php:62

    I'm not really sure if this does the same like before. getRecord does not include deleted records, but hidden ones. I don't remember if Extbase behaves the same here and I would like to have someone double check.
  7. Benni Mack voted on patch set 1 V +1 CR +1 10/07/20, 08:02

  8. Daniel Goerz commented on patch set 1 10/07/20, 16:54

    UsernameViewHelper.php:62 Reply Unresolved

    Now the names of hidden user records are still rendered in the log, which I consider an improvement.
  9. Daniel Goerz voted on patch set 1 V +2 CR +2 10/07/20, 16:55

  10. Daniel Goerz merged patch set 2 10/07/20, 16:55