Review main Merged

66021[BUGFIX] Avoid exceptions during link checking

Georg Ringer CR +2 V +2 Easy +5 −1 updated 10/08/20, 06:56

Commit message

If a rich text field contains a link to a file or folder the current
user doesn't have access to, the thrown exception must be handled and
ignored.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1518

  1. Georg Ringer uploaded patch set 1 10/05/20, 22:05

  2. Georg Ringer commented on patch set 1 10/05/20, 22:06

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 10/05/20, 22:18 Completed build in 12m 49s on Mon, 5 Oct, 10:18 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6253

  4. Josef Glatz voted on patch set 1 CR +1 10/06/20, 06:48

  5. Markus Klein commented on patch set 2 10/06/20, 06:58

    Published edit on patch set 1.
  6. Markus Klein voted on patch set 2 V +1 CR +1 10/06/20, 06:58

  7. TYPO3com voted on patch set 2 V +1 10/06/20, 07:19 Completed build in 15m 57s on Tue, 6 Oct, 07:19 AM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6256

  8. Josef Glatz voted on patch set 2 V +1 CR +1 10/06/20, 09:14

  9. Oliver Klee voted on patch set 2 CR +1 10/06/20, 09:58

  10. Daniel Goerz commented on patch set 2 V -1 10/06/20, 14:35

    Exception still occurs in the Link Wizard
  11. Daniel Goerz uploaded patch set 3 10/06/20, 14:35

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 10/06/20, 14:36

  13. TYPO3com voted on patch set 3 V +1 10/06/20, 14:59 Completed build in 23m 47s on Tue, 6 Oct, 02:59 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6283

  14. Markus Klein commented on patch set 3 10/06/20, 20:33

    RteHtmlParser.php:783

    do we still need this then here, if we already capture this exception in the handler?
  15. Josef Glatz commented on patch set 3 CR +1 10/07/20, 08:04

    RteHtmlParser.php:783 Reply

    as far as I understand: This is used if you edit an existing content element
  16. Josef Glatz voted on patch set 3 V +1 10/07/20, 08:16

  17. Benni Mack commented on patch set 3 V +2 CR +2 10/08/20, 06:56

    RteHtmlParser.php:783 Reply Unresolved

    yes. still needed.
  18. Benni Mack merged patch set 4 10/08/20, 06:56