Review 10.4 Merged

66034[BUGFIX] Do not read workspace if there is no BE user

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/10/20, 19:57

Commit message

Running the PopulatePageSlugs upgrade uses the SlugService
to generate the slugs. SlugService itself uses
BackendUtility::getRecordLocalization() which
does a DB query using a WorkspaceRestriction.
This restriction uses the workspace of the current
BE user. But within the Install Tool upgrade there is no
such user of course.

Add the necessary condition to avoid a PHP type error.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Georg Ringer commented on patch set 1 10/06/20, 08:21

    Cherry Picked from branch master.
  2. Georg Ringer rebased onto patch set 2 10/07/20, 06:42

  3. TYPO3com voted on patch set 2 V +1 10/07/20, 06:58 Completed build in 15m 10s on Wed, 7 Oct, 06:58 AM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-588

  4. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/10/20, 19:57

  5. Anja Leichsenring merged patch set 3 10/10/20, 19:57