Review 10.4 Merged

66035[BUGFIX] Allow LocalDriver baseUri to be set to any value

Georg Ringer CR +2 V +2 Normal +123 −5 updated 10/06/20, 09:37

Commit message

LocalDriver evaluates a configuration option baseUri,
to use this URI instead of a derived one from the absolute
base path of files.

However there are currently limitations that need to be fixed
to allow more complex setups:

1. baseUri is not defined in flexform, thus cannot be set from UI
2. baseUri isn't evaluated, when the absolute file path
   is within TYPO3's public path
3. baseUri is currently required to be a fully qualified URI (with scheme and host)

This change addresses all three of them to cover the following use cases:

1. Provide a different hostname to serve the files from, even
   when they are located on the same machine.
2. Allow base URI without host name, for files that are on the same host,
   but in a folder not within TYPO3's root directory (e.g. due to special
   web server configuration)

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 34

  1. Georg Ringer commented on patch set 1 10/06/20, 09:11

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/06/20, 09:36 Completed build in 25m 17s on Tue, 6 Oct, 09:36 AM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-573

  3. Georg Ringer voted on patch set 1 V +2 CR +2 10/06/20, 09:37

  4. Georg Ringer merged patch set 2 10/06/20, 09:37