Review 10.4 Merged

66036[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:lowlevel

Daniel Goerz CR +2 V +2 Easy +8 −4 updated 10/06/20, 11:54

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 69

  1. Daniel Goerz commented on patch set 1 10/06/20, 11:18

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php * typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php
  2. TYPO3com voted on patch set 1 V -1 10/06/20, 11:19 Completed build in 24s on Tue, 6 Oct, 11:19 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-574

  3. Daniel Goerz uploaded patch set 2 10/06/20, 11:21

  4. TYPO3com voted on patch set 2 V -1 10/06/20, 11:21 Completed build in 25s on Tue, 6 Oct, 11:21 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-575

  5. Daniel Goerz uploaded patch set 3 10/06/20, 11:33

  6. Daniel Goerz commented on patch set 3 10/06/20, 11:34

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V +1 10/06/20, 11:49 Completed build in 15m 31s on Tue, 6 Oct, 11:49 AM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-576

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 10/06/20, 11:54

  9. Daniel Goerz merged patch set 4 10/06/20, 11:54