Review 10.4 Merged

66038[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Crypto

Daniel Goerz CR +2 V +2 Easy +4 −4 updated 10/06/20, 12:49

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Daniel Goerz commented on patch set 1 10/06/20, 12:20

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/06/20, 12:36 Completed build in 15m 59s on Tue, 6 Oct, 12:36 PM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-579

  3. Oliver Klee voted on patch set 1 CR +1 10/06/20, 12:42

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/06/20, 12:49

  5. Daniel Goerz merged patch set 2 10/06/20, 12:49