Review 10.4 Merged

66039[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Imaging

Daniel Goerz CR +2 V +2 Normal +47 −40 updated 10/06/20, 13:45

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 35

  1. Daniel Goerz commented on patch set 1 10/06/20, 12:52

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 10/06/20, 13:14 Completed build in 17m 05s on Tue, 6 Oct, 01:14 PM Test Summary: 1 of 75306 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-580

  3. TYPO3com voted on patch set 1 V +1 10/06/20, 13:41 Completed build in 1h 00m 55s on Tue, 6 Oct, 01:41 PM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-580

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/06/20, 13:45

  5. Daniel Goerz merged patch set 2 10/06/20, 13:45