Review 10.4 Merged

66041[BUGFIX] Use Package as argument type in ServiceProviderRegistry again

Daniel Goerz CR +2 V +2 Easy +3 −3 updated 10/06/20, 15:11

Commit message

With #92263 the type hint for ServiceProviderRegistry->create()
has been changed from Package to PackageInterface which is wrong,
because a method is called that is not part of the interface.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 10/06/20, 14:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/06/20, 15:06 Completed build in 29m 16s on Tue, 6 Oct, 03:06 PM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-583

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/06/20, 15:11

  4. Daniel Goerz merged patch set 2 10/06/20, 15:11