66051[BUGFIX] Fix type error in log upgrade wizard
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2026
Show 1 earlier messages
-
Daniel Goerz commented on patch set 1 10/09/20, 13:30
Cherry Picked from branch master.
-
Daniel Goerz updated the commit message in patch set 2 10/09/20, 13:30
-
Daniel Goerz uploaded patch set 3 10/09/20, 13:33
-
Daniel Goerz voted on patch set 3 CR +1 10/09/20, 13:33
-
Daniel Goerz updated the commit message in patch set 4 10/09/20, 13:36
-
Daniel Goerz commented on patch set 4 10/09/20, 13:36
Please see previous master patch for former discussion on this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64182 -
TYPO3com voted on patch set 1 V +1 10/09/20, 13:44 Completed build in 14m 07s on Fri, 9 Oct, 01:44 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-603
-
TYPO3com voted on patch set 2 V +1 10/09/20, 13:45 Completed build in 15m 02s on Fri, 9 Oct, 01:45 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-604
-
TYPO3com voted on patch set 3 V +1 10/09/20, 13:57 Completed build in 18m 35s on Fri, 9 Oct, 01:57 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-605
-
TYPO3com voted on patch set 4 V +1 10/09/20, 14:01 Completed build in 22m 02s on Fri, 9 Oct, 02:01 PM Test Summary: 74821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-606
-
Oliver Klee voted on patch set 4 CR +1 10/09/20, 14:13
-
Alexander Schnitzler commented on patch set 4 CR -1 10/10/20, 06:16
SeparateSysHistoryFromSysLogUpdate.php:175The index here must be history_data, not log_data, right? -
Daniel Goerz uploaded patch set 5 10/10/20, 07:45
-
Daniel Goerz commented on patch set 5 10/10/20, 07:45
SeparateSysHistoryFromSysLogUpdate.php:175ReplyNice catch! Done -
Daniel Goerz voted on patch set 5 CR +1 10/10/20, 07:46
-
Alexander Schnitzler voted on patch set 5 V +1 CR +1 10/10/20, 07:46
-
TYPO3com voted on patch set 5 V +1 10/10/20, 07:58 Completed build in 13m 23s on Sat, 10 Oct, 07:58 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-607
-
Oliver Klee voted on patch set 5 CR +1 10/10/20, 10:31
-
Oli Bartsch commented on patch set 5 10/12/20, 09:08
SeparateSysHistoryFromSysLogUpdate.php:393Why this null coalescing? We have already ensured $serialized to be a string with the type hint. -
Daniel Goerz uploaded patch set 6 10/12/20, 09:21
-
Daniel Goerz commented on patch set 6 V +1 CR +1 10/12/20, 09:21
SeparateSysHistoryFromSysLogUpdate.php:393ReplyDone -
TYPO3com voted on patch set 6 V +1 10/12/20, 09:35 Completed build in 13m 32s on Mon, 12 Oct, 09:35 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-613
-
Oli Bartsch voted on patch set 6 V +1 CR +1 10/12/20, 09:37
-
Alexander Schnitzler voted on patch set 6 V +1 CR +1 10/12/20, 10:29
-
Daniel Goerz voted on patch set 6 V +2 CR +2 10/12/20, 10:55
-
Daniel Goerz merged patch set 7 10/12/20, 10:55