Review 10.4 Merged

66051[BUGFIX] Fix type error in log upgrade wizard

Daniel Goerz CR +2 V +2 Easy +10 −8 updated 10/12/20, 10:55

Commit message

During the update, the value of the field log_data is
unserialized. The expected value is an array, but it was
never validated. If the field contains an invalid value,
unserialize() returns a boolean false.

Now the result is type casted to an array to ensure the
correct type.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2026

Show 1 earlier messages
  1. Daniel Goerz commented on patch set 1 10/09/20, 13:30

    Cherry Picked from branch master.
  1. Daniel Goerz updated the commit message in patch set 2 10/09/20, 13:30

  2. Daniel Goerz uploaded patch set 3 10/09/20, 13:33

  3. Daniel Goerz voted on patch set 3 CR +1 10/09/20, 13:33

  4. Daniel Goerz updated the commit message in patch set 4 10/09/20, 13:36

  5. Daniel Goerz commented on patch set 4 10/09/20, 13:36

    Please see previous master patch for former discussion on this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64182
  6. TYPO3com voted on patch set 1 V +1 10/09/20, 13:44 Completed build in 14m 07s on Fri, 9 Oct, 01:44 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-603

  7. TYPO3com voted on patch set 2 V +1 10/09/20, 13:45 Completed build in 15m 02s on Fri, 9 Oct, 01:45 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-604

  8. TYPO3com voted on patch set 3 V +1 10/09/20, 13:57 Completed build in 18m 35s on Fri, 9 Oct, 01:57 PM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-605

  9. TYPO3com voted on patch set 4 V +1 10/09/20, 14:01 Completed build in 22m 02s on Fri, 9 Oct, 02:01 PM Test Summary: 74821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-606

  10. Oliver Klee voted on patch set 4 CR +1 10/09/20, 14:13

  11. Alexander Schnitzler commented on patch set 4 CR -1 10/10/20, 06:16

    SeparateSysHistoryFromSysLogUpdate.php:175

    The index here must be history_data, not log_data, right?
  12. Daniel Goerz uploaded patch set 5 10/10/20, 07:45

  13. Daniel Goerz commented on patch set 5 10/10/20, 07:45

    SeparateSysHistoryFromSysLogUpdate.php:175 Reply

    Nice catch! Done
  14. Daniel Goerz voted on patch set 5 CR +1 10/10/20, 07:46

  15. Alexander Schnitzler voted on patch set 5 V +1 CR +1 10/10/20, 07:46

  16. TYPO3com voted on patch set 5 V +1 10/10/20, 07:58 Completed build in 13m 23s on Sat, 10 Oct, 07:58 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-607

  17. Oliver Klee voted on patch set 5 CR +1 10/10/20, 10:31

  18. Oli Bartsch commented on patch set 5 10/12/20, 09:08

    SeparateSysHistoryFromSysLogUpdate.php:393

    Why this null coalescing? We have already ensured $serialized to be a string with the type hint.
  19. Daniel Goerz uploaded patch set 6 10/12/20, 09:21

  20. Daniel Goerz commented on patch set 6 V +1 CR +1 10/12/20, 09:21

    SeparateSysHistoryFromSysLogUpdate.php:393 Reply

    Done
  21. TYPO3com voted on patch set 6 V +1 10/12/20, 09:35 Completed build in 13m 32s on Mon, 12 Oct, 09:35 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-613

  22. Oli Bartsch voted on patch set 6 V +1 CR +1 10/12/20, 09:37

  23. Alexander Schnitzler voted on patch set 6 V +1 CR +1 10/12/20, 10:29

  24. Daniel Goerz voted on patch set 6 V +2 CR +2 10/12/20, 10:55

  25. Daniel Goerz merged patch set 7 10/12/20, 10:55