Review 9.5 Abandoned

66056[BUGFIX] Make external link checking more robust

Sybille Peters CR 0 V 0 Easy +22 −14 updated 10/15/20, 12:03

Commit message

This is a backport of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/65636 to 9.5.

Previously, some URLs could result in errors which were not caught and
caused the link checking task to abort.

ExternalLinktype::preprocessUrl() now returns original URL in case
of any error, catches errors and exception and does some sanity
checking of parsed URLs before using the results.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Sybille Peters uploaded patch set 1 10/06/20, 12:40

  2. TYPO3com voted on patch set 1 V +1 10/06/20, 13:05 Completed build in 25m 18s on Tue, 6 Oct, 01:05 PM Test Summary: 75203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-828

  3. Rémy DANIEL commented on patch set 1 V +1 CR +1 10/06/20, 13:53

    Tested successfuly on 9.5 Given a page with an unreachable external link on it: - without the patch, linkvalidator fails with an exception : > Argument 1 passed to TYPO3\CMS\Core\Utility\HttpUtility::idn_to_ascii() must be of the type string, null given, called in /var/www/html/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php on line 225 - with the patch, linkvalidator checks the page and the report shows the errored link
  4. Sybille Peters abandoned the change 10/15/20, 11:57

    Is backport of Change-Id: I60c73f9081e7ecd7b67c3c726d3d759d9d9baa1b Should have same Change-Id
  5. Sybille Peters commented on patch set 1 10/15/20, 12:03

    Please review and test: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66146 I had to recreate a new patch because the backported patch should have same Change-Id as original patch. I did not know this and this is the first time I did this.