Review main Merged

66057[BUGFIX] Use Package as argument type in ServiceProviderRegistry again

Daniel Goerz CR +2 V +2 Easy +3 −3 updated 10/06/20, 14:36

Commit message

With #92263 the type hint for ServiceProviderRegistry->create()
has been changed from Package to PackageInterface which is wrong,
because a method is called that is not part of the interface.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Daniel Goerz uploaded patch set 1 10/06/20, 14:01

  2. Alexander Schnitzler voted on patch set 1 V +1 CR +1 10/06/20, 14:03

  3. Daniel Goerz wrote 10/06/20, 14:11

    Topic set to phpstan
  4. TYPO3com voted on patch set 1 V +1 10/06/20, 14:19 Completed build in 17m 33s on Tue, 6 Oct, 02:19 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6280

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 10/06/20, 14:36

  6. Daniel Goerz merged patch set 2 10/06/20, 14:36