Review main Merged

66058[BUGFIX] Provide original message and envelope to transport

Simon Gilli CR +2 V +2 Easy +1 −1 updated 10/13/20, 18:34

Commit message

The interface Symfony\Component\Mailer\Transport\TransportInterface
expects a RawMessage and an optional Envelope if it's not already part
of RawMessage. Currently an instance of Symfony\Component\Mailer\SentMessage
is sent which is not compatible.

This patch changes this behavior to send the original message and the
envelope like already done in the MemorySpool.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Gerdes +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Gerdes +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Simon Gilli uploaded patch set 1 10/06/20, 14:46

  2. Simon Gilli updated the commit message in patch set 2 10/06/20, 14:58

  3. TYPO3com voted on patch set 1 V +1 10/06/20, 15:06 Completed build in 16m 51s on Tue, 6 Oct, 03:06 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6285

  4. TYPO3com voted on patch set 2 V +1 10/06/20, 15:16 Completed build in 16m 15s on Tue, 6 Oct, 03:16 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6286

  5. Simon Gilli wrote 10/06/20, 15:28

    Description "Edit commit message" removed
  6. Markus Gerdes voted on patch set 2 V +1 CR +1 10/13/20, 08:58

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/20, 18:34

  8. Christian Kuhn merged patch set 3 10/13/20, 18:34