Review 10.4 Merged

66059[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Resource

Daniel Goerz CR +2 V +2 Normal +59 −49 updated 10/06/20, 18:14

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 78

  1. Daniel Goerz uploaded patch set 1 10/06/20, 14:52

  2. Oliver Klee voted on patch set 1 CR +1 10/06/20, 15:10

  3. TYPO3com voted on patch set 1 V +1 10/06/20, 15:13 Completed build in 17m 52s on Tue, 6 Oct, 03:13 PM Test Summary: 74820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-584

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/06/20, 15:13

  5. Daniel Goerz merged patch set 2 10/06/20, 15:13

  6. Helmut Hummel commented on patch set 2 10/06/20, 17:04

    LocalDriver.php:1237

    That is quite a functional change here, that mutes potential errors, doen't it?
  7. Daniel Goerz commented on patch set 2 10/06/20, 18:12

    LocalDriver.php:1237 Reply

    You are right that this is a functional change as it returns false now for inaccessible or nonexistent folders. This change in behavior was unintended. My bad. It does not mute the PHP warning that is emitted when calling opendir() with an invalid path. I will fix this in the backport directly and return true instead, so the current behavior does not change. For master we can do the same and either add a log entry or even throw an exeption which of course would be breaking. What would be your suggestion/ expected behavior?
  8. Daniel Goerz commented on patch set 2 10/06/20, 18:14

    LocalDriver.php:1237 Reply Unresolved

    Forget the sentence about the backport, as this is already merged, I got ahead of myself -.- One can only process so many phpstan patches per day, I guess ...