Review main Merged

66061[BUGFIX] Revert typo3/testing-framework providing prophecy trait

Anja Leichsenring CR +2 V +2 Easy +12 −12 updated 10/06/20, 18:23

Commit message

The typo3/testing-framework 6.4.4 included a backport of the prophecy
trait that is required for phpunit v10 and causes lots of deprecation
messages in phpunit v9.
This backport causes problems with phpunit v8, though. So the inclusion
is reverted.

Used command:
	composer require --dev typo3/testing-framework:^6.4.5

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 46

  1. Anja Leichsenring uploaded patch set 1 10/06/20, 17:58

  2. Anja Leichsenring updated the commit message in patch set 2 10/06/20, 18:07

  3. TYPO3com voted on patch set 1 V +1 10/06/20, 18:14 Completed build in 16m 34s on Tue, 6 Oct, 06:14 PM Test Summary: 73783 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6297

  4. TYPO3com voted on patch set 2 V +1 10/06/20, 18:22 Completed build in 15m 37s on Tue, 6 Oct, 06:22 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6298

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/06/20, 18:23

  6. Anja Leichsenring merged patch set 3 10/06/20, 18:23