Review main Merged

66065[BUGFIX] Restore behavior of LocalDriver->isFolderEmpty()

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 10/08/20, 08:44

Commit message

With #92264 the behavior of the public function
LocalDriver->isFolderEmpty() has been changed for invalid
input. As this was an unintended change, the former behavior
is restored with this patch.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Files 1

Review log 78

  1. Daniel Goerz uploaded patch set 1 10/07/20, 07:57

  2. Daniel Goerz wrote 10/07/20, 07:57

    Topic set to phpstan
  3. Daniel Goerz commented on patch set 1 10/07/20, 07:59

  4. TYPO3com voted on patch set 1 V +1 10/07/20, 08:10 Completed build in 12m 41s on Wed, 7 Oct, 08:10 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6307

  5. Oliver Klee voted on patch set 1 CR +1 10/07/20, 10:45

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 10/08/20, 08:30

  7. Georg Ringer voted on patch set 1 V +2 CR +2 10/08/20, 08:44

  8. Georg Ringer merged patch set 2 10/08/20, 08:44