Review main Merged Breaking

66066[!!!][FEATURE] Always initialize frontend groups after FE user

Benni Mack CR +2 V +2 Normal +99 −57 updated 10/19/20, 18:32

Commit message

In previous TYPO3 versions (due to historic reasons) the frontend
groups were always resolved within TSFE when a page and the
rootline was resolved.

However, this left the actual Frontend User, which is initialized
at the very beginning of a frontend request, in an incomplete state:
A user was (correctly) found and "logged in", but the groups were
resolved at a later point.

This was due to the fact that the Admin Panel allowed to
"include hidden records" which also considered fe_groups,
and thus be set later-on.

This change now moved the resolving of the groups (and setting
the right frontend.user aspect) right after the user resolving.

This means that the groups are now available much earlier, and not
bound to the TSFE instance anymore, allowing to use Middlewares much
more professionally without depending on TSFE for custom Routing / APIs.

Future options:
It would even be possible to filter out PageRouter pages that are
not available, which would make the Router itself faster.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1929

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 10/07/20, 10:23

  2. TYPO3com voted on patch set 1 V -1 10/07/20, 10:38 Completed build in 15m 12s on Wed, 7 Oct, 10:38 AM Test Summary: 147 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6314

  3. Benni Mack uploaded patch set 2 10/07/20, 20:12

  4. TYPO3com voted on patch set 2 V -1 10/07/20, 20:32 Completed build in 20m 05s on Wed, 7 Oct, 08:32 PM Test Summary: 148 of 74273 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6340

  1. Benni Mack rebased onto patch set 3 10/08/20, 18:59

  2. TYPO3com voted on patch set 3 V -1 10/08/20, 19:13 Completed build in 14m 08s on Thu, 8 Oct, 07:13 PM Test Summary: 147 of 74249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6385

  3. Patrick Schriner commented on patch set 3 10/09/20, 07:22

    This should not be considered a feature, but a bugfix: I stumbled upon this in TYPO3 10 because an Errorhandler cannot use $context->getPropertyFromAspect('frontend.user', 'isLoggedIn') to check whether we have a logged in user or not. Stackoverflow (https://stackoverflow.com/questions/63109489/typo3-access-restricted-pages-redirect-after-login) seems to suggest that this used to work in TYPO3 9.
  4. Benni Mack commented on patch set 3 10/09/20, 07:25

    > Patch Set 3: > > This should not be considered a feature, but a bugfix: > I stumbled upon this in TYPO3 10 because an Errorhandler cannot use $context->getPropertyFromAspect('frontend.user', 'isLoggedIn') to check whether we have a logged in user or not. > Stackoverflow (https://stackoverflow.com/questions/63109489/typo3-access-restricted-pages-redirect-after-login) seems to suggest that this used to work in TYPO3 9. I guess this could be fixed differently as a bugfix https://review.typo3.org/c/Packages/TYPO3.CMS/+/64441
  5. Benni Mack uploaded patch set 4 10/13/20, 11:46

  6. Benni Mack uploaded patch set 5 10/13/20, 11:49

  7. TYPO3com voted on patch set 4 V -1 10/13/20, 12:05 Completed build in 18m 11s on Tue, 13 Oct, 12:05 PM Test Summary: 147 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6468

  8. TYPO3com voted on patch set 5 V -1 10/13/20, 12:05 Completed build in 16m 17s on Tue, 13 Oct, 12:05 PM Test Summary: 147 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6469

  9. Benni Mack uploaded patch set 6 10/13/20, 13:45

  10. TYPO3com voted on patch set 6 V -1 10/13/20, 13:59 Completed build in 13m 31s on Tue, 13 Oct, 01:59 PM Test Summary: 147 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6475

  11. Benni Mack rebased onto patch set 7 10/13/20, 14:02

  12. TYPO3com voted on patch set 7 V -1 10/13/20, 14:20 Completed build in 17m 45s on Tue, 13 Oct, 02:20 PM Test Summary: 147 of 74201 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6476

  13. Benni Mack rebased onto patch set 8 10/13/20, 19:53

  14. TYPO3com voted on patch set 8 V +1 10/13/20, 20:07 Completed build in 13m 44s on Tue, 13 Oct, 08:07 PM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6505

  15. Benni Mack uploaded patch set 9 10/14/20, 08:01

  16. TYPO3com voted on patch set 9 V +1 10/14/20, 08:14 Completed build in 12m 56s on Wed, 14 Oct, 08:14 AM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6511

  17. Markus Klein commented on patch set 9 10/14/20, 15:17

  18. Christian Kuhn uploaded patch set 10 10/15/20, 11:11

  19. Christian Kuhn voted on patch set 10 V +1 CR +1 10/15/20, 11:12

  20. TYPO3com voted on patch set 10 V +1 10/15/20, 11:26 Completed build in 14m 24s on Thu, 15 Oct, 11:26 AM Test Summary: 73702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6553

  21. Markus Klein commented on patch set 10 V -1 CR -1 10/15/20, 13:28

    Please lets fix https://review.typo3.org/c/Packages/TYPO3.CMS/+/66053 first for all versions and apply this one afterwards
  22. Markus Klein voted on patch set 10 V 0 CR +1 10/16/20, 15:52

  23. Anja Leichsenring voted on patch set 10 V +1 CR +1 10/19/20, 18:31

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 10/19/20, 18:31

  25. Christian Kuhn merged patch set 11 10/19/20, 18:32