Review main Merged

66067[TASK] Do not call determineId() twice

Benni Mack CR +2 V +2 Easy +9 −23 updated 10/08/20, 18:58

Commit message

Due to legacy reasons before PSR-15 middlewares were introduced,
there was a hook to re-evaluate the Page ID via TSFE->determineId()
which was popular with RealURL.

$TSFE->determineId() was called twice when logged-in backend users
were accessing a page they did not have access to, with a clean state,
however TSFE->determineId() does the same check already as well,
so it is not needed to call determineId() twice anymore, because the
hook was removed in TYPO3 v10.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 10/07/20, 10:33

  2. TYPO3com voted on patch set 1 V +1 10/07/20, 10:51 Completed build in 17m 41s on Wed, 7 Oct, 10:51 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6315

  3. Benni Mack updated the commit message in patch set 2 10/07/20, 11:25

  4. TYPO3com voted on patch set 2 V +1 10/07/20, 11:44 Completed build in 15m 22s on Wed, 7 Oct, 11:44 AM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6322

  5. Oli Bartsch commented on patch set 2 10/08/20, 08:46

    TypoScriptFrontendController.php:811 Unresolved

    constructor argument is the default, so could be skipped if not provided intentionally.
  6. Benni Mack commented on patch set 3 10/08/20, 11:40

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 10/08/20, 11:59 Completed build in 19m 14s on Thu, 8 Oct, 11:59 AM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6361

  8. Georg Ringer voted on patch set 3 CR +1 10/08/20, 18:40

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 10/08/20, 18:53

  10. Georg Ringer voted on patch set 3 V +2 CR +2 10/08/20, 18:58

  11. Georg Ringer merged patch set 4 10/08/20, 18:58