Review main Abandoned Breaking

66068[WIP][!!!][TASK] Remove GET/POST parameter no_cache

Benni Mack CR 0 V 0 Easy +5 −26 updated 10/22/20, 21:00

Commit message

The functionality to set the "&no_cache=1" GET Parameter is removed
from TYPO3 Core.

This functionality provides severe issues where TYPO3 allows to bypass
the caching mechanism by ANY PERSON OR MACHINE.

The option $TYPO3_CONF_VARS[FE][disableNoCacheParameter]
was used previously to not care about this flag, but is now removed as well.

It is recommended to use
a) Plugins with USER_INT / Content via COA_INT

Using "config.no_cache = 1" is still supported if this functionality is really needed.

All TypoScript options have been removed as well.

If a project really needs the functionality via a GET parameter,
it can be built very easily with a middleware in a custom extension.

ToDo:
* SilentConfigurationUpgrader to remove the option
* Remove any other usage in Fluid / Extbase for this flag
* RST file

Review

  • Code review CR 0
  • Verified V 0

Files 9

Review log 23

  1. Benni Mack uploaded patch set 1 10/07/20, 10:44

  2. TYPO3com voted on patch set 1 V -1 10/07/20, 11:05 Completed build in 21m 26s on Wed, 7 Oct, 11:05 AM Test Summary: 24 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6317

  3. Benni Mack abandoned the change 10/22/20, 21:00